Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add moreh_matmul op #3188

Closed
dongjin-na opened this issue Oct 16, 2023 · 0 comments
Closed

Add moreh_matmul op #3188

dongjin-na opened this issue Oct 16, 2023 · 0 comments
Assignees
@dongjin-na
Labels
feature-request External feature request moreh moreh contribution

Comments

@dongjin-na
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Implement moreh_matmup op compatible with torch.mamtul as part of SOW.

Describe the solution you'd like
moreh_matmul op supports

  • dot product (1d tensors)
  • matmul (2d tensors)
  • batched matmul (up to 4d tensors)
  • transpose support for second input tensor (weight)
  • mask on padded area of tile
  • kernel is based on bmm/multi_core

Additional context

  • optimized kernel, transpose for first input tensor (activation) will be implemented after this issue.
@dongjin-na dongjin-na added feature-request External feature request moreh moreh contribution labels Oct 16, 2023
@dongjin-na dongjin-na self-assigned this Oct 16, 2023
@dongjin-na dongjin-na mentioned this issue Oct 18, 2023
Merged
dongjin-na added a commit that referenced this issue Oct 20, 2023
@dongjin-na
#3188: Add moreh_matmul op
371d52c
dongjin-na added a commit that referenced this issue Oct 20, 2023
@dongjin-na
#3188: apply review feedback
0fbe0be
dongjin-na added a commit that referenced this issue Oct 20, 2023
@dongjin-na
#3188: refactor get_bcast_batch
0f3eca7
dongjin-na added a commit that referenced this issue Oct 20, 2023
@dongjin-na
#3188: Add moreh_matmul op
981ab03
dongjin-na added a commit that referenced this issue Oct 20, 2023
@dongjin-na
#3188: apply review feedback
42eb587
dongjin-na added a commit that referenced this issue Oct 20, 2023
@dongjin-na
#3188: refactor get_bcast_batch
98edb5a
@dongjin-na dongjin-na mentioned this issue Oct 23, 2023
Merged
razorback3 pushed a commit that referenced this issue Oct 31, 2023
@dongjin-na
#3188: Add moreh_matmul op
9a06343
razorback3 pushed a commit that referenced this issue Oct 31, 2023
@dongjin-na
#3188: apply review feedback
9bc47db
razorback3 pushed a commit that referenced this issue Oct 31, 2023
@dongjin-na
#3188: refactor get_bcast_batch
2c5a08f
dongjin-na added a commit that referenced this issue Nov 3, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
07d59ce
dongjin-na added a commit that referenced this issue Nov 3, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
3bf5572
seunghwan100 pushed a commit that referenced this issue Nov 3, 2023
@dongjin-na @seunghwan100
#3188: Add using tt_metal in moreh_matmul header
d612a23
dongjin-na added a commit that referenced this issue Nov 4, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
49fa069
dongjin-na added a commit that referenced this issue Nov 4, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
38ba158
dongjin-na added a commit that referenced this issue Nov 6, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
cb0aadf
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: Add moreh_matmul op
fbc0e04
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: apply review feedback
27af785
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: refactor get_bcast_batch
823a2cc
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
29e63ed
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: Add moreh_matmul op
e97b952
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: Revise moreh_matmul op
5e86269
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: refactor get_bcast_batch
1b53106
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
905922a
dongjin-na added a commit that referenced this issue Nov 17, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
91ec2b3
razorback3 pushed a commit that referenced this issue Nov 21, 2023
@dongjin-na
#3188: Add moreh_matmul op
cf0f5e7
razorback3 pushed a commit that referenced this issue Nov 21, 2023
@dongjin-na
#3188: apply review feedback
90637eb
razorback3 pushed a commit that referenced this issue Nov 21, 2023
@dongjin-na
#3188: refactor get_bcast_batch
4ab1c0a
ilkoo-lee pushed a commit that referenced this issue Nov 21, 2023
@dongjin-na
#3188: Add moreh_matmul op
cb55ef3
ilkoo-lee pushed a commit that referenced this issue Nov 21, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
d412c8b
ilkoo-lee pushed a commit that referenced this issue Nov 21, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
9431880
dongjin-na added a commit that referenced this issue Nov 22, 2023
@dongjin-na
#3188: Add moreh_matmul op
964b9da
dongjin-na added a commit that referenced this issue Nov 22, 2023
@dongjin-na
#3188: Revise moreh_matmul op
2fa26fd
dongjin-na added a commit that referenced this issue Nov 22, 2023
@dongjin-na
#3188: refactor get_bcast_batch
66916e7
dongjin-na added a commit that referenced this issue Nov 22, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
b3d0c62
dongjin-na added a commit that referenced this issue Nov 22, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
1339893
dongjin-na added a commit that referenced this issue Nov 23, 2023
@dongjin-na
#3188: Add moreh_matmul op
f9cdccb
dongjin-na added a commit that referenced this issue Nov 23, 2023
@dongjin-na
#3188: Revise moreh_matmul op
16464c9
dongjin-na added a commit that referenced this issue Nov 23, 2023
@dongjin-na
#3188: refactor get_bcast_batch
ca97a68
dongjin-na added a commit that referenced this issue Nov 23, 2023
@dongjin-na
#3188: Add using tt_metal in moreh_matmul header
81dac19
dongjin-na added a commit that referenced this issue Nov 23, 2023
@dongjin-na
#3188: Refactoring moreh_matmul op
4358ebb
muthutt pushed a commit that referenced this issue Nov 25, 2023
@dongjin-na @muthutt
#3188: Add moreh_matmul op
1dac884
muthutt pushed a commit that referenced this issue Nov 25, 2023
@dongjin-na @muthutt
#3188: Revise moreh_matmul op
b2241d3
muthutt pushed a commit that referenced this issue Nov 25, 2023
@dongjin-na @muthutt
#3188: refactor get_bcast_batch
8ea1f30
muthutt pushed a commit that referenced this issue Nov 25, 2023
@dongjin-na @muthutt
#3188: Add using tt_metal in moreh_matmul header
921659e
muthutt pushed a commit that referenced this issue Nov 25, 2023
@dongjin-na @muthutt
#3188: Refactoring moreh_matmul op
4ef43b1
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in External Requests and Reports Dec 1, 2023
This was referenced Sep 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dongjin-na dongjin-na

Labels
feature-request External feature request moreh moreh contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dongjin-na