Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12250: port moreh_matmul from tt_dnn to ttnn #12251

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

o2buzzle
Copy link
Contributor

@o2buzzle o2buzzle commented Sep 5, 2024

Ticket

#12250

Problem description

moreh_matmul (introduced in #3188 ) was deprecated when tt_dnn was moved into deprecated state. Port it to the top level ttnn package instead

What's changed

  • Disabled moreh_matmul's tt_dnn implementations
  • Move device code to ttnn
  • Create new wrapper code for ttnn with new modules
  • Ported unit tests to ttnn

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Additional notes

  • moreh_matmul's old implementation has NOT been removed, just disabled, as moreh_matmul_backward depends on it and is being worked on by another team member.
  • This operation is currently missing a portion that allows it to do 1xN * Nx1 due to moreh_dot not being ready yet. This will be added as soon as #12207: Port moreh_dot to ttnn #12249 is merged.
  • This is reflected in Unit tests

@o2buzzle o2buzzle added the moreh moreh contribution label Sep 5, 2024
@o2buzzle o2buzzle self-assigned this Sep 5, 2024
@o2buzzle o2buzzle force-pushed the o2buzzle/port_moreh_matmul branch 2 times, most recently from be38074 to ba185dd Compare September 13, 2024 12:50
@o2buzzle
Copy link
Contributor Author

Post-commit checks look OK: https://github.com/tenstorrent/tt-metal/actions/runs/10851569390.
I’m merging this ticket now.

@o2buzzle o2buzzle merged commit fce2044 into main Sep 14, 2024
6 checks passed
@o2buzzle o2buzzle deleted the o2buzzle/port_moreh_matmul branch September 14, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moreh moreh contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants