-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12250: port moreh_matmul from tt_dnn to ttnn #12251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o2buzzle
requested review from
eyonland,
patrickroberts,
yan-zaretskiy,
cfjchu,
xanderchin,
TT-BrianLiu,
ayerofieiev-tt,
dmakoviichuk-tt,
razorback3,
dongjin-na,
tt-aho and
mywoodstock
as code owners
September 5, 2024 06:47
o2buzzle
force-pushed
the
o2buzzle/port_moreh_matmul
branch
from
September 5, 2024 06:49
2c42b62
to
c128fe5
Compare
o2buzzle
force-pushed
the
o2buzzle/port_moreh_matmul
branch
2 times, most recently
from
September 13, 2024 12:50
be38074
to
ba185dd
Compare
o2buzzle
force-pushed
the
o2buzzle/port_moreh_matmul
branch
from
September 13, 2024 15:03
ba185dd
to
2514067
Compare
o2buzzle
force-pushed
the
o2buzzle/port_moreh_matmul
branch
from
September 14, 2024 05:44
2514067
to
d603842
Compare
Post-commit checks look OK: https://github.com/tenstorrent/tt-metal/actions/runs/10851569390. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#12250
Problem description
moreh_matmul
(introduced in #3188 ) was deprecated whentt_dnn
was moved into deprecated state. Port it to the top levelttnn
package insteadWhat's changed
Checklist
Additional notes
moreh_matmul_backward
depends on it and is being worked on by another team member.1xN * Nx1
due tomoreh_dot
not being ready yet. This will be added as soon as #12207: Port moreh_dot to ttnn #12249 is merged.