Pkeller/memmap profiler #12067
Merged
Pkeller/memmap profiler #12067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-tenstorrent
requested review from
aliuTT,
ubcheema,
abhullar-tt,
pgkeller,
tt-aho,
tt-dma and
tt-asaigal
as code owners
mo-tenstorrent
force-pushed
the
pkeller/memmap-profiler
branch
from
96590b4
to
27b0ea9
Compare
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
temporarily deployed
to
production
GitHub Actions
Inactive
mo-tenstorrent
force-pushed
the
pkeller/memmap-profiler
branch
2 times, most recently
from
36b8f47
to
38e1832
Compare
pgkeller
force-pushed
the
pkeller/memmap-profiler
branch
from
38e1832
to
ebae03a
Compare
pgkeller
approved these changes
Sep 15, 2024
Storage cores used to include mailboxes for the L1 barrier L1 barrier is no longer in the mailboxes, so update the base address to the base of the mailboxes
With split prefetcher/dispatcher the downstream component sets the MSB of the credit a terminate signal. The credit balancing wait waited for the credits to match the expected credits but didn't account for the terminate signal. This would result in a hang if the downstream component finished before the upstream omponent (which should be and was rare).
And out of the common runtime address map
pgkeller
force-pushed
the
pkeller/memmap-profiler
branch
from
ebae03a
to
ff6513d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#4984
Problem description
Profiler is using the old L1 addressing scheme
What's changed
Make profiler use the mailbox struct to share its address between device and host
Checklist