#12527: refactor slice #12791
Merged
#12527: refactor slice #12791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjameelTT
requested review from
esmalTT,
uaydonat,
mywoodstock,
shwetankTT,
tt-aho,
cglagovichTT,
caixunshiren,
yieldthought,
mtairum,
djordje-tt,
johanna-rock-tt,
kpaigwar,
skhorasganiTT,
tt-rkim,
eyonland,
patrickroberts,
yan-zaretskiy,
cfjchu,
xanderchin,
TT-BrianLiu,
ayerofieiev-tt,
dmakoviichuk-tt,
razorback3,
dongjin-na,
SeanNijjar and
ntarafdar
as code owners
sjameelTT
force-pushed
the
sjameel/slice_refactor
branch
from
52decdf
to
d133a7a
Compare
-use exclusive ends and move all the list splicing-exclusive features to ttnn.slice -use exclusive ends for ttnn.unpad -add support for negative starts -add negative starts and ends support to ttnn.slice -move most pre-processing to C++ -refactor C++ code -remove skip on bert ttnn.slice unit tests -support 1D, 2D, 3D inputs on ttnn.slice
sjameelTT
force-pushed
the
sjameel/slice_refactor
branch
from
d133a7a
to
c12ed6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-use exclusive ends and move all the list splicing features to ttnn.slice
-add support for negative starts
-add negative starts and ends support to ttnn.slice
-move most pre-processing to C++
-refactor C++ code
-remove skip on bert ttnn.slice unit tests
Ticket
Link to Github Issue
Problem description
ttnn.slice and the tensor[..start:end:step] format had differences in feature support. Refactor slice to improve coverage.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist