Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept doc comments when deriving ShaderType #42

Merged
merged 2 commits into from
May 9, 2023
Merged

accept doc comments when deriving ShaderType #42

merged 2 commits into from
May 9, 2023

Conversation

mockersf
Copy link
Contributor

@mockersf mockersf commented May 8, 2023

Since the migration to syn 2 (#35), doc comments are not accepted:

test tests/pass/attributes.rs [should pass] ... error
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈
error: expected `(`
  --> tests/pass/attributes.rs:24:5
   |
24 |     /// This is an unisgned integer
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈

This PR stops checking attributes that are not owned by this crate

@mockersf mockersf mentioned this pull request May 8, 2023
Closed
@mockersf mockersf mentioned this pull request May 8, 2023
Merged
@mockersf @matthiasbeyer
typo
4e4971a 
Co-authored-by: Matthias Beyer <mail@beyermatthias.de>
@mockersf mockersf changed the title accept doc comments accept doc comments when deriving ShaderToy May 8, 2023
@mockersf mockersf changed the title accept doc comments when deriving ShaderToy accept doc comments when deriving ShaderType May 8, 2023
teoxoy
teoxoy approved these changes May 9, 2023
View reviewed changes
Copy link
Owner

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Will publish a new patch release soon.

@teoxoy teoxoy merged commit 0b6d6b4 into teoxoy:main May 9, 2023
github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this pull request May 16, 2023
@mockersf @nicopap @JoJoJet
update syn, encase, glam and hexasphere (#8573)
0736195 
# Objective

- Fixes #8282 
- Update `syn` to 2.0, `encase` to 0.6, `glam` to 0.24 and `hexasphere`
to 9.0


Blocked ~~on teoxoy/encase#42 and ~~on
OptimisticPeach/hexasphere#17

---------

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer left review comments

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @matthiasbeyer @teoxoy