Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packaging type of artifacts without java files should be pom #519

Closed
1 task done
ikeyat opened this issue Mar 17, 2016 · 0 comments
Closed
1 task done

Packaging type of artifacts without java files should be pom #519

ikeyat opened this issue Mar 17, 2016 · 0 comments
Assignees
@btkadotahr
Labels
type: improvement version: 5.2.0
Milestone
2016 summer

Comments

@ikeyat
Copy link
Contributor

ikeyat commented Mar 17, 2016 •
edited by yoshikawaa
Loading

Description

Artifacts that are just for managing dependencies of libraries and have no java files should be pom type.
But following artifacts are set as jar type or omitted (default type is pom).

  • terasoluna-gfw-mybatis3
  • terasoluna-gfw-jpa
  • terasoluna-gfw-security-core

Because of the setting, we have empty jars for them.
Those are not harmful but it is confusing and may increase the cost of management of libraries.

Possible Solutions

Set packaging type as pom.

 <packaging>pom</packaging>

Affects Version/s

  • 5.1.0.RELEASE
  • 5.0.2.RELEASE
  • 1.0.4.RELEASE

Fix Version/s

  • 5.2.0.RELEASE

Issue Links
@ikeyat ikeyat added this to the 2016 summer milestone Mar 17, 2016
@ikeyat ikeyat changed the title Packing type of artifacts that have no java files should be pom Packaging type of artifacts without java files should be pom Mar 17, 2016
@ikeyat ikeyat assigned kumagaikzk and unassigned btundes Mar 17, 2016
@kazuki43zoo kazuki43zoo modified the milestones: 2016 summer, 2017 winter Mar 28, 2016
@ikeyat ikeyat added the ready label Apr 13, 2016
@kazuki43zoo kazuki43zoo modified the milestones: 2016 summer, 2017 winter Apr 25, 2016
@ikeyat ikeyat assigned btkadotahr and unassigned kumagaikzk Apr 26, 2016
btkadotahr added a commit that referenced this issue Apr 27, 2016
@btkadotahr
update [terasoluna-gfw-jpa] and [terasoluna-gfw-mybatis3] and [teraso…
ff0839e 
…luna-gfw-security-core] pom.xml. #519
@btkadotahr btkadotahr mentioned this issue May 9, 2016
Closed
1 task
btkadotahr added a commit that referenced this issue May 9, 2016
@btkadotahr
Set 'pom' to Packaging type of artifacts and add 'version' and 'type'…
bea3bef 
… to dependency due #519
This was referenced May 9, 2016
Closed
Closed
btkadotahr added a commit that referenced this issue May 11, 2016
@btkadotahr
Set 'pom' to Packaging type of artifacts and add 'type' to dependency…
6b01f49 
… due #519
This was referenced May 11, 2016
Merged
Merged
yoshikawaa added a commit that referenced this issue May 12, 2016
@yoshikawaa
Merge pull request #553 from terasolunaorg/issues/519_FixPom_UpdateTy…
e49e3a6 
…peAndDependency_master

Set 'pom' to Packaging type of artifacts and add 'type' to dependency due #519
@btkadotahr btkadotahr mentioned this issue May 12, 2016
Closed
2 tasks
@yoshikawaa yoshikawaa removed the ready label May 12, 2016
This was referenced May 13, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btkadotahr btkadotahr

Labels
type: improvement version: 5.2.0
Projects
None yet
Milestone
2016 summer
Development

No branches or pull requests
6 participants
@kazuki43zoo @ikeyat @yoshikawaa @kumagaikzk @btundes @btkadotahr