Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate pom.xml dependencies for app and common lib #508

Closed
1 task done
ikeyat opened this issue Feb 29, 2016 · 4 comments
Closed
1 task done

Separate pom.xml dependencies for app and common lib #508

ikeyat opened this issue Feb 29, 2016 · 4 comments
Assignees
@bttanakagn
Labels
type: improvement type: misc version: 5.2.0
Milestone
2016 summer

Comments

@ikeyat
Copy link
Contributor

ikeyat commented Feb 29, 2016 •
edited
Loading

Description

Now we define TERASOLUNA Stack libraries in pom.xml of each common libraries.
But for maintainability, it should be separated the dependencies that are just stacks (not used by common libraries directly) or used by common libraries.

In other words, All dependencies in common libraries (e.g. terasoluna-gfw-common) should be used by common libraries directly. Other dependencies should be defined other separated pom.xml such as terasoluna-gfw-recommended
The concept is similar to xxx-starter in Spring Boot.

Possible Solutions

  • Identify all dependencies which they are used or not used by common libraries.
  • Define new pom.xml files lineup for each purpose like common, web, jsp, security, rest, jpa, mybatis3, etc...

Affects Version/s

N/A

Fix Version/s

  • 5.2.0

Issue Links
@ikeyat ikeyat added this to the 5.2.0 milestone Feb 29, 2016
@ikeyat ikeyat changed the title Separate pom.xml for dependencies of app and common lib Separate pom.xml dependencies for app and common lib Feb 29, 2016
@ikeyat ikeyat added the ready label Mar 1, 2016
@btkatoutmj btkatoutmj modified the milestones: 2016 summer, 5.2.0 Mar 9, 2016
btundes pushed a commit that referenced this issue Mar 9, 2016
@sandeepunde
Initial Commit : pom polishing (polished common and jodatime libraries)
ad6f470 
#508
btundes pushed a commit that referenced this issue Mar 11, 2016
@sandeepunde
updated the parent project reference #508
bad1757
btundes pushed a commit that referenced this issue Mar 11, 2016
@sandeepunde
Polished gfw-web and gfw-web-jsp libraries #508
a8e9a15
btundes pushed a commit that referenced this issue Mar 14, 2016
@sandeepunde
changed the terasoluna-gfw-jpa terasoluna-gfw-starter-jpa #508
4df9de5
btundes pushed a commit that referenced this issue Mar 14, 2016
@sandeepunde
updated the artifactId as the artifact itself is modified #508
ecb8729
btundes pushed a commit that referenced this issue Mar 14, 2016
@sandeepunde
changed the terasoluna-gfw-mybatis3 to terasoluna-gfw-starter-mybatis3 …
c2d007f 
…#508
btundes pushed a commit that referenced this issue Mar 14, 2016
@sandeepunde
updated artifacts names in the artifact list #508
09b930c
btundes pushed a commit that referenced this issue Mar 15, 2016
@sandeepunde
corrected the parent artifactid #508
e0b0c49
btundes pushed a commit that referenced this issue Mar 15, 2016
@sandeepunde
corrected the parent-artifactid for each refactored artifacts #508
6f45904
btundes pushed a commit that referenced this issue Mar 16, 2016
@sandeepunde
Refactored security-web and updated dependencies in web & web-jsp #508
b3b9e11
btundes pushed a commit that referenced this issue Mar 16, 2016
@sandeepunde
renamed terasoluna-gfw-starter-common to terasoluna-gfw-starter #508
b6f2c95
btundes pushed a commit that referenced this issue Mar 16, 2016
@sandeepunde
corrected the artifact id #508
fa858c0
@ikeyat ikeyat mentioned this issue Mar 17, 2016
Closed
1 task
btundes pushed a commit that referenced this issue Mar 17, 2016
@sandeepunde
added starter artifacts temporarily to gfw-parent #508
0ea549c
btundes pushed a commit that referenced this issue Mar 17, 2016
@sandeepunde
corrected the folder struture #508
f81f075
btundes pushed a commit that referenced this issue Mar 17, 2016
@sandeepunde
corrected the folder struture #508
f0a9a3f
btundes pushed a commit that referenced this issue Mar 22, 2016
@sandeepunde
refactored to group the starter artifacts into single parent starter #…
93b110a 
…508
This was referenced Mar 24, 2016
Closed
Closed
@kazuki43zoo kazuki43zoo modified the milestones: 2016 summer, 2017 winter Mar 28, 2016
@bttanakagn bttanakagn reopened this Jul 8, 2016
bttanakagn added a commit that referenced this issue Jul 8, 2016
@bttanakagn
add new comments to categorize properties #508
cdc4747
@bttanakagn bttanakagn mentioned this issue Jul 8, 2016
Merged
bttanakagn added a commit that referenced this issue Jul 8, 2016
@bttanakagn
swap properties position #508
565456b
yoshikawaa added a commit that referenced this issue Jul 8, 2016
@yoshikawaa
Merge pull request #578 from terasolunaorg/issues/508_POM_Polishing
5aaeab2 
add new comments to categorize properties #508
bttanakagn added a commit that referenced this issue Jul 15, 2016
@bttanakagn
remove duplicate dependencies #508
37a348d
@bttanakagn bttanakagn reopened this Jul 15, 2016
@bttanakagn bttanakagn mentioned this issue Jul 15, 2016
Merged
bttanakagn added a commit that referenced this issue Jul 15, 2016
@bttanakagn
remove duplicate dependencies #508
aaf998d
yoshikawaa added a commit that referenced this issue Jul 15, 2016
@yoshikawaa
Merge pull request #581 from terasolunaorg/issues/508_POM_Polishing_m…
1d3db9d 
…odify_dependency

remove duplicate dependencies #508
@bttanakagn bttanakagn reopened this Jul 28, 2016
bttanakagn added a commit that referenced this issue Jul 28, 2016
@bttanakagn
apply new dependencies projects #508
fdf3ce8
bttanakagn added a commit that referenced this issue Jul 28, 2016
@bttanakagn
insert a line feed before the comment #508
c51dd13
@bttanakagn bttanakagn mentioned this issue Jul 28, 2016
Merged
bttanakagn added a commit that referenced this issue Jul 29, 2016
@bttanakagn
add deficient artifacts #508
3a179ee
bttanakagn added a commit that referenced this issue Jul 29, 2016
@bttanakagn
add description of terasoluna-gfw-codepoints #508
04b6301
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
apply new dependencies projects #508
cd72395
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
insert a line feed before the comment #508
1ecab06
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
add deficient artifacts #508
290a6d0
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
add description of terasoluna-gfw-codepoints #508
da2ae10
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
remove catalog of codepoints like guideline #508
2782cb8
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
arrange the order like the guideline #508
49af6de
bttanakagn added a commit that referenced this issue Aug 1, 2016
@bttanakagn
arrange the order again #508
05f9684
yoshikawaa added a commit that referenced this issue Aug 1, 2016
@yoshikawaa
Merge pull request #607 from terasolunaorg/issues/508_modify_readme
5b2cc05 
modify readme.md about pom polishing #508
@kazuki43zoo kazuki43zoo mentioned this issue Sep 9, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bttanakagn bttanakagn

Labels
type: improvement type: misc version: 5.2.0
Projects
None yet
Milestone
2016 summer
Development

No branches or pull requests
8 participants
@kazuki43zoo @ikeyat @yoshikawaa @btundes @btkatoutmj @bttanakagn @btkadotahr @sasakitsy