Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify readme.md about pom polishing #508 #607

Merged
merged 7 commits into from
Aug 1, 2016
Merged

modify readme.md about pom polishing #508 #607

merged 7 commits into from
Aug 1, 2016

Conversation

bttanakagn
Copy link
Contributor

Please review #508.

@bttanakagn bttanakagn changed the title modify readme.md about pom polishing modify readme.md about pom polishing #508 Jul 28, 2016
@coveralls
Copy link

coveralls commented Jul 28, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.66% when pulling c51dd13 on issues/508_modify_readme into 6def4f8 on master.

@yoshikawaa
Copy link
Contributor

@bttanakagn
Are not required follow descriptions?

  • terasoluna-gfw-common-dependencies
  • terasoluna-gfw-validator
  • terasoluna-gfw-string
  • terasoluna-gfw-codepoints

@yoshikawaa yoshikawaa added this to the 2016 summer milestone Jul 28, 2016
@coveralls
Copy link

coveralls commented Jul 29, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.66% when pulling 3a179ee on issues/508_modify_readme into 6def4f8 on master.

@bttanakagn
Copy link
Contributor Author

@btyoshikawaa
I added those artifacts except for terasoluna-gfw-common-dependencies, because terasoluna-gfw-web-dependencies depends on it.

@coveralls
Copy link

coveralls commented Jul 29, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.66% when pulling 04b6301 on issues/508_modify_readme into 6def4f8 on master.

yoshikawaa
yoshikawaa reviewed Jul 29, 2016
View reviewed changes
README.md
@@ -83,6 +83,12 @@ After adding above, add the following dependency definitions.

<!-- OPTIONAL -->
<dependency>
<groupId>org.terasoluna.gfw</groupId>
<artifactId>terasoluna-gfw-codepoints</artifactId>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In guideline, codepoints component is shown terasoluna-gfw-codepoints only. Let to align to it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please be arranged to order of string, codepoints, validator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btyoshikawaa
I removed the descriptions about catalog. 2782cb8.
and arranged the order of string,codepoints,validator. 49af6de.

@bttanakagn bttanakagn force-pushed the issues/508_modify_readme branch from 04b6301 to 49af6de Compare August 1, 2016 02:04
@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.751% when pulling 49af6de on issues/508_modify_readme into 37a349d on master.

@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 96.751% when pulling 05f9684 on issues/508_modify_readme into 37a349d on master.

@yoshikawaa yoshikawaa merged commit 5b2cc05 into master Aug 1, 2016
@yoshikawaa yoshikawaa deleted the issues/508_modify_readme branch August 1, 2016 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
version: 5.2.0
Projects
None yet
Milestone
2016 summer
Development

Successfully merging this pull request may close these issues.
4 participants
@bttanakagn @coveralls @yoshikawaa @ikeyat