feat: add delete timeout to aws_autoscaling_group

[filintod]

PR o'clock

Description

Adding timeout to asg deletion as sometimes it can take more than the default 10m in our case.

FEATURES:

• Added option to customize timeout delete for autoscaling groups. It can be done via
  workers_group_defaults.asg_delete_timeout as a golang duration or in each template or config
  via delete_timeout.

Checklist

• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[github-actions]

Thank you for your contribution!

The CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts.
Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request.

[daroga0002]

we should address this issue in same way as in node groups:

terraform-aws-eks/modules/node_groups/main.tf

Lines 81 to 85 in 253f927

	timeouts {
	create = lookup(each.value["timeouts"], "create", null)
	update = lookup(each.value["timeouts"], "update", null)
	delete = lookup(each.value["timeouts"], "delete", null)
	}

to make a consistent user experience.

@filintod do you will be able to make this change?

[filintod]

@daroga0002 I can do it but next week if that works.

[daroga0002]

@filintod do you plan to implement changes?

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[filintod]

@daroga0002 sorry for the delay. updated the timeout to follow node groups format

[daroga0002]

@daroga0002 sorry for the delay. updated the timeout to follow node groups format

could you paste here some example of module configuration (this will make a testing faster)?

[filintod]

@daroga0002 an example would be like:

module "eks" {
  source           = "terraform-aws-modules/eks/aws"
  // other configs....

  workers_group_defaults = {
    asg_force_delete = true

    # double delete timeout default value
    timeouts = {
      delete = "20m"
    }
  }
}

[daroga0002]

this should be customized via workers_group_defaults["timeouts"] but also via timeouts setting per particulal worker definition as rest of parameters which are defined here https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/locals.tf

[filintod]

added an extra lookup against the per particular worker definition

[daroga0002]

This will work, but in general this is in other way as other variables. Please review and use same pattern which we arleady using

[filintod]

@daroga0002 could you explain/point out to me as I did not find it.

In node_groups, timeouts is used like:

  timeouts {
    create = lookup(each.value["timeouts"], "create", null)
    update = lookup(each.value["timeouts"], "update", null)
    delete = lookup(each.value["timeouts"], "delete", null)
  }

where each is from https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/node_groups/main.tf#L2 where they have timeouts as timeouts = var.workers_group_defaults["timeouts"]

I guess I could add timeouts in locals.tf. But not sure if that is overkill as that was not added before, and from what I can see it would just change local.workers_group_defaults["timeouts"] for local.timeouts. Let me know or please point me to an example as I did not see anything similar from my point of view.

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[antonbabenko]

This issue has been resolved in version 18.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.