Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete timeout to aws_autoscaling_group #1566

Closed
wants to merge 4 commits into from
Closed

feat: add delete timeout to aws_autoscaling_group #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfbb882
update timeouts make consistent
Sep 2, 2021
72c09f0
fix bug
Nov 10, 2021
e00095b
allow per worker/worker_launch_group timeout not only defaults
Nov 10, 2021
da2a640
nicer formatting
Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion workers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,14 @@ resource "aws_autoscaling_group" "workers" {
"capacity_rebalance",
local.workers_group_defaults["capacity_rebalance"]
)

timeouts {
delete = lookup(
lookup(
var.worker_groups[count.index],
"timeouts",
local.workers_group_defaults["timeouts"]
), "delete", null)
}
dynamic "initial_lifecycle_hook" {
for_each = var.worker_create_initial_lifecycle_hooks ? lookup(var.worker_groups[count.index], "asg_initial_lifecycle_hooks", local.workers_group_defaults["asg_initial_lifecycle_hooks"]) : []
content {
Expand Down
8 changes: 8 additions & 0 deletions workers_launch_template.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,14 @@ resource "aws_autoscaling_group" "workers_launch_template" {
"capacity_rebalance",
local.workers_group_defaults["capacity_rebalance"]
)
timeouts {
delete = lookup(
lookup(
var.worker_groups_launch_template[count.index],
"timeouts",
local.workers_group_defaults["timeouts"]
), "delete", null)
}

dynamic "mixed_instances_policy" {
iterator = item
Expand Down