Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum terraform version to include yamlencode #570

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

toadjaune
Copy link
Contributor

@toadjaune toadjaune commented Oct 24, 2019

https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md#0122-june-12-2019

PR o'clock

Description

Bump minimum terraform version in order to avoid the following errors :

Error: Call to unknown function

  on .terraform/modules/my-cluster/terraform-aws-modules-terraform-aws-eks-1be1a02/aws_auth.tf line 82, in data "template_file" "config_map_aws_auth":
  82:     map_users    = yamlencode(var.map_users),

There is no function named "yamlencode".


Error: Call to unknown function

  on .terraform/modules/my-cluster/terraform-aws-modules-terraform-aws-eks-1be1a02/aws_auth.tf line 83, in data "template_file" "config_map_aws_auth":
  83:     map_roles    = yamlencode(var.map_roles),

There is no function named "yamlencode".


Error: Call to unknown function

  on .terraform/modules/my-cluster/terraform-aws-modules-terraform-aws-eks-1be1a02/aws_auth.tf line 84, in data "template_file" "config_map_aws_auth":
  84:     map_accounts = yamlencode(var.map_accounts)

There is no function named "yamlencode".

Checklist

@toadjaune
Copy link
Contributor Author

I'm not certain if this requires anything to be done in README and/or CHANGELOG

Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@barryib
Copy link
Member

barryib commented Oct 25, 2019

@toadjaune Thanks for your PR. Can you please add this to the chagelog ?

@toadjaune
Copy link
Contributor Author

There you go :)

@barryib barryib merged commit c90b337 into terraform-aws-modules:master Oct 25, 2019
@toadjaune toadjaune deleted the fix-minimum-value branch October 25, 2019 09:19
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants