Add Action check against minimum versions

[dpiddockcmp]

PR o'clock

Description

Add a Github Action check to try to validation the minimum versions listed. This won't catch everything but it does catch the two recent cases:

• yamlencode() use from terraform 0.12.2 Increase minimum terraform version to include yamlencode #570
• tags on aws_eks_cluster in aws 2.31.0 Add tags to eks cluster introduced by terraform-provider-aws 2.31.0 #550

Checklist

• Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[max-rocket-internet]

Good idea @dpiddockcmp

Maybe we should just set all hashicorp/terraform:latest to hashicorp/terraform:0.12.2?

[dpiddockcmp]

Hi Max.

Do you mean instead of this check? As this check is also validating the providers' minimum versions.

[max-rocket-internet]

I meant we are already running the fmt job with hashicorp/terraform:latest: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/.github/workflows/lint.yml#L17

And validate with hashicorp/terraform:latest: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/.github/workflows/lint.yml#L36

So I was thinking we just switch all of these to 0.12.2 but now I think about it, you're saying we should validate for current latest AND our current minimum. Is that correct?

[dpiddockcmp]

Personally, I hate the use of :latest as it can easily add unpredictable breakages to CI runs, like every time the terraform minor version increases. No doubt 1.0 or 0.13 will cause issues again.

I think it would be a good idea to set static version numbers for the other tests. This may not necessarily be the minimum of the module:

• terraform fmt from 0.12.2 incorrectly complains about aws_auth.tf and data.tf but 0.12.6 and later do not.
• examples include other modules which may have their own terraform restrictions. Currently only VPC is used which does not specify versions.

[max-rocket-internet]

Personally, I hate the use of :latest as it can easily add unpredictable breakages

I agree. It's especially bad in docker 😅

I think it would be a good idea to set static version numbers for the other tests

I get the concept but the problem is that people will just brew install terraform, get the latest version and then use this module, and perhaps have an issue. But we need to know if the latest version has a problem with this module.

So I think we merge this and see how it goes unless someone has a better idea.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.