feat: Update IAM policy for AWS Load Balancer Controller to support Listener Attributes #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istener Attributes
jstewart612
changed the title
chore: Requested comma addition for git history simplification Co-authored-by: Aleksei Vesnin <aleksei@vesnin.me>
chore: Requested comma addition for git history simplification Co-authored-by: Aleksei Vesnin <aleksei@vesnin.me>
|
@aleskiontherun suggestions committed. |
bryantbiggs
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
thank you!
would you mind submitting a similar PR to https://github.com/terraform-aws-modules/terraform-aws-eks-pod-identity as well?!
antonbabenko
pushed a commit
that referenced
this pull request
Oct 4, 2024
## [5.46.0](v5.45.0...v5.46.0) (2024-10-04) ### Features * Update IAM policy for AWS Load Balancer Controller to support Listener Attributes ([#525](#525)) ([966c4f8](966c4f8))
|
This PR is included in version 5.46.0 🎉 |
|
@bryantbiggs will do shortly |
|
terraform-aws-modules/terraform-aws-eks-pod-identity#18 filed to address it there. PR to fix it there will be linked there @bryantbiggs . |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to update the iam-role-for-service-accounts-eks module to add additional permissions when attach_load_balancer_controller_policy is set to true.
Motivation and Context
Addresses #524. Stems from upstream updates to https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/main/docs/install/iam_policy.json that have not yet been ported into this module.
Resolves #524
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request