-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Managed Rules for AWS WAF #11046
Comments
Reference: #11046 Following the [Contributing Guide](https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-service). Output from acceptance testing: ``` --- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.08s) --- PASS: TestAccAWSProvider_Endpoints (3.10s) ```
Submitted the wafv2 service client and tagging implementation to kick things off here: #11172 I believe WAFv2 APIs are wholly independent of previous WAF "Classic" resources, so this issue may need to turn into multiple feature requests to support other WAFv2 resources as well like Web ACL for parity with the previous ones. |
Split out other related WAFv2 feature requests:
In WAFv2 it appears that referencing managed rules is based on name and vendor name arguments that live inside the much more complicated (compared to WAF Classic) rule structure, which you can see in #11175 and #11176. As for this feature request issue, I'm not sure if we should keep those open to track overall WAFv2 implementation, close it in preference of the split out issues, or if there's much benefit to having something akin to the below since the name/vendor lookup is the same (and not like the references need to be ARNs or some other identifier): data "aws_wafv2_managed_rule_group" "example" {
name = ""
scope = ""
vendor_name = ""
} |
) Reference: #11046 Following the [Contributing Guide](https://github.com/terraform-providers/terraform-provider-aws/blob/master/.github/CONTRIBUTING.md#new-service). Output from acceptance testing: ``` --- PASS: TestAccAWSProvider_Endpoints_Deprecated (3.08s) --- PASS: TestAccAWSProvider_Endpoints (3.10s) ```
I'm very happy to see that this is being implemented. Is this planned for any specific version? |
@wgorski I don't think so, next step is getting the PRs to be reviewed. |
Hi Y’all! Due to the significant community interest in support for this service, we will be focusing on enabling existing contributions to be merged. Where a community sourced pull request is missing, the Hashicorp team will add support. We appreciate all the contributions and feedback thus far! Look out for WAFv2 support to be within the next few releases! |
We have started using the |
Hi @itsSaad! 👋 Support for logging configuration has just been released in |
As the last item for this meta issue has been release I will close this meta-issue. Huge thanks to @pvanbuijtene for the contributions! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Description
AWS WAF announces AWS Managed Rules (AMRs), a set of AWS WAF rules curated and maintained by the AWS Threat Research Team.
New or Affected Resource(s)
Potential Terraform Configuration
References
Announcement.
Blog post.
New API version,
wafv2
; See aws/aws-sdk-go#2976.Requires AWS SDK v1.25.42:
The text was updated successfully, but these errors were encountered: