resource/aws_dx_hosted_private_virtual_interface: Update resource to support MTU param #6142

slapula · 2018-10-13T05:02:10Z

Changes proposed in this pull request:

Updated aws_dx_hosted_private_virtual_interface resource to support new MTU parameter

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAwsDxHostedPrivateVirtualInterface_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_basic
--- SKIP: TestAccAwsDxHostedPrivateVirtualInterface_basic (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.022s

… MTU param

…support MTU param

ewbankkit · 2018-10-13T11:07:39Z

ewbankkit · 2018-10-13T11:14:48Z

aws/resource_aws_dx_hosted_private_virtual_interface.go

+				Computed: true,
+				ForceNew: true,
+			},
+			"jumbo_frame_enabled": {


See comment on attribute naming: https://github.com/terraform-providers/terraform-provider-aws/pull/6141/files#r224957129.

ewbankkit · 2018-10-13T11:15:33Z

See comment on adding verification to acceptance tests: #6141 (comment).

ewbankkit · 2018-10-13T20:48:53Z

aws/resource_aws_dx_hosted_private_virtual_interface.go

@@ -77,6 +77,16 @@ func resourceAwsDxHostedPrivateVirtualInterface() *schema.Resource {
 				ForceNew:     true,
 				ValidateFunc: validateAwsAccountId,
 			},
+			"mtu": {


Add a ValidateFunc to ensure that the value is 1500 or 9001.

ewbankkit · 2018-10-13T20:54:05Z

aws/resource_aws_dx_hosted_private_virtual_interface.go

+				Type:     schema.TypeInt,
+				Default:  1500,
+				Optional: true,
+				ForceNew: true,


It looks like the MTU value for a VIF can be update via the UpdateVirtualInterface API method, so ForceNew should not be set.
This will entail adding an Update method to the resources.

ewbankkit · 2018-10-23T16:20:57Z

@slapula Can I take a look at this one now?

…u' into slapula-dx-hosted-private-virtual-interfarce-mtu

ewbankkit · 2018-10-23T17:18:50Z

@slapula I ran your new acceptance test on the code. I had to fix a couple of minor things - merge error and incorrect resource type in the test - and pushed them to https://github.com/ewbankkit/terraform-provider-aws/tree/slapula-dx-hosted-private-virtual-interfarce-mtu.

$ DX_HOSTED_VIF_OWNER_ACCOUNT=000000000000 DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate (85.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	102.660s

ewbankkit · 2018-10-23T17:20:31Z

If you merge in the changes from my branch I will be able to run the full set of tests from your branch.

slapula · 2018-10-24T00:06:27Z

@ewbankkit This one should be ready to move forward now.

ewbankkit · 2018-10-24T13:06:25Z

Acceptance tests:

$ git rev-parse HEAD
0089b9fae2b65015aa93e3b1d0f2e7f6b7a648dc
$ DX_HOSTED_VIF_OWNER_ACCOUNT=000000000000 DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxHostedPrivateVirtualInterface_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_basic
=== CONT  TestAccAwsDxHostedPrivateVirtualInterface_basic
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_basic (34.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	35.576s
$ DX_HOSTED_VIF_OWNER_ACCOUNT=000000000000 DX_CONNECTION_ID=dxcon-xxxxxxxx AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_mtuUpdate (96.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	97.793s

This PR is now ready for review.
#6141 should be merged first as this PR contains commits from that PR.

bflad

Thanks @slapula and @ewbankkit! 🚀

bflad · 2018-11-01T00:20:58Z

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-02T17:44:12Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

slapula added 3 commits October 12, 2018 22:47

resource/aws_dx_private_virtual_interface: Update resource to support…

5298e48

… MTU param

fixing mtu int handling

d549990

resource/aws_dx_hosted_private_virtual_interface: Update resource to …

8b4ed89

…support MTU param

slapula added 2 commits October 13, 2018 00:21

exporting value of jumbo frames param

b5f9c82

exporting value of jumbo frames param

6282f06

ewbankkit mentioned this pull request Oct 13, 2018

resource/aws_dx_connection: Export bool value of new MTU parameter #6143

Merged

ewbankkit mentioned this pull request Oct 13, 2018

resource/aws_dx_private_virtual_interface: Update resource to support MTU param #6141

Merged

ewbankkit reviewed Oct 13, 2018

View reviewed changes

slapula added 3 commits October 13, 2018 08:01

adding acc test for mtu

cdecb24

correcting exported value name

4b3d2f0

adding acc test for mtu

7a1f9b8

ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Oct 13, 2018

slapula added 2 commits October 13, 2018 08:41

setting default for mtu

c4593cc

setting default for mtu

c6c438e

ewbankkit reviewed Oct 13, 2018

View reviewed changes

ewbankkit mentioned this pull request Oct 14, 2018

Feature request: Direct Connect support for changing network MTU #6136

Closed

slapula and others added 6 commits October 14, 2018 22:06

validating mtu input & adding expanding vif update function

636db33

adding acc test for updating mtu

257a94a

'IntInSlice' -> 'validateIntegerInSlice'.

4cff326

Add Update timeout to r/aws_dx_private_virtual_interface.

0cf60ab

Merge branch 'master' into slapula-dx-private-virtual-interface-mtu

83b25df

pulling in ewbankkit changes

bd5798b

slapula added 7 commits October 22, 2018 12:38

forgot a missing file from previous commit

1d75428

Merge branch 'master' into dx-private-virtual-interface-mtu

6f8738b

fixing merge conflict

1e6b61a

removing conflict cruft

77e465a

changing 1 to true

da69517

Merge branch 'master' into dx-hosted-private-virtual-interfarce-mtu

ad2ce09

adding improvements from dx-private-virtual-interfarce-mtu branch

2478fba

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Oct 23, 2018

Kit Ewbank added 2 commits October 23, 2018 12:46

Merge remote-tracking branch 'slapula/dx-private-virtual-interface-mt…

2aa7a45

…u' into slapula-dx-hosted-private-virtual-interfarce-mtu

Fix typos in acceptance tests.

0089b9f

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 23, 2018

ewbankkit mentioned this pull request Oct 24, 2018

r/aws_dx_private_virtual_interface: Error running parallel acceptance tests #6244

Closed

bflad added this to the v1.42.0 milestone Oct 30, 2018

bflad approved these changes Oct 30, 2018

View reviewed changes

bflad merged commit 42f8202 into hashicorp:master Oct 30, 2018

bflad added a commit that referenced this pull request Oct 30, 2018

Update CHANGELOG for #6142

a0cffe1

ghost locked and limited conversation to collaborators Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource/aws_dx_hosted_private_virtual_interface: Update resource to support MTU param #6142

resource/aws_dx_hosted_private_virtual_interface: Update resource to support MTU param #6142

slapula commented Oct 13, 2018

ewbankkit commented Oct 13, 2018

ewbankkit Oct 13, 2018

ewbankkit commented Oct 13, 2018

ewbankkit Oct 13, 2018

ewbankkit Oct 13, 2018

ewbankkit commented Oct 23, 2018

ewbankkit commented Oct 23, 2018

ewbankkit commented Oct 23, 2018

slapula commented Oct 24, 2018

ewbankkit commented Oct 24, 2018

bflad left a comment

bflad commented Nov 1, 2018

ghost commented Apr 2, 2020

resource/aws_dx_hosted_private_virtual_interface: Update resource to support MTU param #6142

resource/aws_dx_hosted_private_virtual_interface: Update resource to support MTU param #6142

Conversation

slapula commented Oct 13, 2018

ewbankkit commented Oct 13, 2018

ewbankkit Oct 13, 2018

Choose a reason for hiding this comment

ewbankkit commented Oct 13, 2018

ewbankkit Oct 13, 2018

Choose a reason for hiding this comment

ewbankkit Oct 13, 2018

Choose a reason for hiding this comment

ewbankkit commented Oct 23, 2018

ewbankkit commented Oct 23, 2018

ewbankkit commented Oct 23, 2018

slapula commented Oct 24, 2018

ewbankkit commented Oct 24, 2018

bflad left a comment

Choose a reason for hiding this comment

bflad commented Nov 1, 2018

ghost commented Apr 2, 2020