This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Read and used in page objects #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopaul
force-pushed
the
ReadAndUsedInPageObjects
branch
from
dbab6ea
to
aaedc24
Compare
|
needs to be rebased because of conflict after merging #74 |
slu-it
reviewed
Jan 12, 2017
| @@ -190,6 +192,7 @@ public void deselectByIndices(final Integer... indices) { | |||
| String index = option.getAttribute("index"); | |||
| allSelectedIndices.add(Integer.valueOf(index)); | |||
| } | |||
| this.markAsRead(); | |||
There was a problem hiding this comment.
all of these this.markAsRead() could be replaced by adding the marking to the public List<WebElement> getAllSelectedOptions() method
slu-it
reviewed
Jan 12, 2017
| @@ -300,6 +307,7 @@ public Integer execute(PageObject pageObject) { | |||
|
|
|||
| @Override | |||
| public List<String> execute(PageObject pageObject) { | |||
| pageObject.markAsRead(); | |||
There was a problem hiding this comment.
Most of the pageObject.markAsRead(); could be replaced by putting them into getAllSelectedOptions(), getFirstSelectedOption() and getAllOptions()
slu-it
reviewed
Jan 12, 2017
| try { | ||
| pageObject.markAsRead(); |
There was a problem hiding this comment.
can be moved to getSelectedOption()
…GenericTextField and MultiSelect
nicopaul
force-pushed
the
ReadAndUsedInPageObjects
branch
from
aaedc24
to
1816b38
Compare
…electedOption()`, `getAllOptions()` and `getSelectedOption()` for better understanding
|
Review status: 0 of 6 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Reviewed 3 of 6 files at r1, 3 of 3 files at r2. Comments from Reviewable |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch where I added
markAsRead()to relevant methods of multiple page objects#74 is required for this pull request
This change is