Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Read and used in page objects #75

Merged
merged 5 commits into from
Jan 16, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public class Button extends PageObject implements HasValue<String>, HasLabel {
*/
@Override
public String getValue() {
this.markAsRead();
return StringUtils.defaultString(getAttribute("value"));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ public void pressEnter() {

@Override
public void execute(PageObject pageObject) {
pageObject.markAsUsed();
pageObject.getWebElement().sendKeys(Keys.ENTER);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ public void execute(PageObject pageObject) {
* @since 1.2
*/
public void deselectAll() {
this.markAsUsed();
getSelect().deselectAll();
}

Expand All @@ -111,6 +112,7 @@ public void deselectAll() {
* @since 1.2
*/
public void deselectByTexts(final String... texts) {
this.markAsUsed();
for (String text : texts) {
getSelect().deselectByVisibleText(text);
}
Expand All @@ -125,6 +127,7 @@ public void deselectByTexts(final String... texts) {
* @since 1.2
*/
public void deselectByValues(final String... values) {
this.markAsUsed();
for (String value : values) {
getSelect().deselectByValue(value);
}
Expand All @@ -139,6 +142,7 @@ public void deselectByValues(final String... values) {
* @since 1.2
*/
public void deselectByIndices(final Integer... indices) {
this.markAsUsed();
for (Integer index : indices) {
getSelect().deselectByIndex(index);
}
Expand Down Expand Up @@ -195,6 +199,7 @@ public List<Integer> getAllSelectedIndices() {


public List<WebElement> getAllSelectedOptions() {
this.markAsRead();
return getSelect().getAllSelectedOptions();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ public String getVisibleText() {

@Override
public String execute(PageObject pageObject) {
pageObject.markAsRead();
return getWebElement().getText();
}

Expand Down Expand Up @@ -506,6 +507,10 @@ protected final void markAsRead() {
Marker.markAsRead(this);
}

protected final void markAsUsed() {
Marker.markAsUsed(this);
}

/**
* Creates a new instance for the given {@linkplain PageObject page object}
* class using the {@linkplain Browser browser's} creation mechanism. This
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -367,14 +367,17 @@ private EnhancedSelect getSelect() {
}

private List<WebElement> getAllOptions() {
this.markAsRead();
return getSelect().getOptions();
}

private List<WebElement> getAllSelectedOptions() {
this.markAsRead();
return getSelect().getAllSelectedOptions();
}

private WebElement getFirstSelectedOption() {
this.markAsRead();
return getSelect().getFirstSelectedOption();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public String getSelectionText() {
return executeAction(new PageObjectCallbackWithReturnValue<String>() {

@Override
public String execute(PageObject arg) {
public String execute(PageObject pageObject) {
try {
String text = getSelectedOption().getText();
return text;
Expand All @@ -125,7 +125,7 @@ public String getSelectionValue() {
return executeAction(new PageObjectCallbackWithReturnValue<String>() {

@Override
public String execute(PageObject arg) {
public String execute(PageObject pageObject) {
try {
String value = getSelectedOption().getAttribute("value");
return value;
Expand All @@ -149,7 +149,7 @@ public Integer getSelectionIndex() {
return executeAction(new PageObjectCallbackWithReturnValue<Integer>() {

@Override
public Integer execute(PageObject arg) {
public Integer execute(PageObject pageObject) {
try {
String indexAsString = getSelectedOption().getAttribute("index");
return Integer.valueOf(indexAsString);
Expand All @@ -162,6 +162,7 @@ public Integer execute(PageObject arg) {
}

public WebElement getSelectedOption() {
this.markAsRead();
return getSelect().getFirstSelectedOption();
}
}