fix: upgrade docker client

[Slijkhuis]

What does this PR do?

Upgrades the github.com/docker/docker package.

The AuthConfig type was moved: moby/moby#43885. 👈 not relevant since I'm not upgrading to v24 anymore, but rather use the backported fix on v23.

Possibly https://github.com/testcontainers/moby-ryuk must be upgraded as well.

Why is it important?

You cannot use testcontainers-go with Go 1.20.6 currently, this PR should fix that.

Related issues

• Closes [Bug]: go 1.20.6: "http: invalid Host header, host port waiting failed" #1359

[netlify]

✅ Deploy Preview for testcontainers-go ready!

Name	Link
🔨 Latest commit	7ac9a90
🔍 Latest deploy log	https://app.netlify.com/sites/testcontainers-go/deploys/64b6d8bc4bf7d30008d8b4e9
😎 Deploy Preview	https://deploy-preview-1361--testcontainers-go.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[bryan-aguilar]

Another option would be to use the latest patch version of v23.0.x as the fix was backported.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[Slijkhuis]

To reduce the scope of the PR I've reverted the changes that were required for upgrading the client to v24. I sticked with v23, but now use the backported fix, as @bryan-aguilar advised.

[Slijkhuis]

FYI: as mentioned in the issue there is a discussion on whether to revert the changes that caused this to be a problem in the first place: golang/go#61431.

[davideme]

Any ETA on when have a release including this fix? It's blocking our CI pipeline for now.

[Slijkhuis]

Any ETA on when have a release including this fix? It's blocking our CI pipeline for now.

I can't merge it, it needs an approving review from @testcontainers/go-team. Which I also cannot tag.

[lanwen]

Hey @davideme you could try a workaround meanwhile

go get -u github.com/docker/docker@v23.0.7-0.20230718082441-f860ed7c77fc+incompatible

that worked for me

[AlexanderYastrebov]

@Slijkhuis I am not from the testcontainers/go-team but rather in the users' boat :)

[mdelapenya]

Hey folks, please take a look at #653.

I'll be back on Aug 1st and will prioritize this issue, which I've been actively following between diapers and baby bottles

[Slijkhuis]

Hey folks, please take a look at #653.

I'll be back on Aug 1st and will prioritize this issue, which I've been actively following between diapers and baby bottles

Sorry, I completely missed that issue. I'll be in the world of diapers and baby bottles myself somewhere early August :). So if you're back and I'm not responding just take control of this PR yourself!

[smhmayboudi]

it would be very nice to check this pull request.

[mdelapenya]

I think we have a potential fix here: #1394. It supersedes this PR, as it includes bumps of the Docker dependency across all the modules, including updating deprecated APIs.