Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Typing in auth #691

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

Tranquility2
Copy link
Contributor

Lets try and continue the journey from #305
(the goal is to get core marked as typed)

poetry run mypy --config-file pyproject.toml core/tests/test_auth.py core/testcontainers/core/auth.py
Success: no issues found in 2 source files

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2cf5a9f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/testcontainers/core/auth.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage        ?   77.81%           
=======================================
  Files           ?       12           
  Lines           ?      604           
  Branches        ?       90           
=======================================
  Hits            ?      470           
  Misses          ?      107           
  Partials        ?       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tranquility2
Copy link
Contributor Author

I know #504 also exists but I feel we need to make it into smaller iteration to get the a goal, treating each core component as a milestone doesn't mean it will all be perfect (time and other commits are bound to make a mess) but it should allow us to get much closer so that the the last mile will be much simpler.

@alexanderankin alexanderankin changed the title fix: typing in core auth fix(core): typing in auth Aug 22, 2024
@Tranquility2 Tranquility2 changed the title fix(core): typing in auth fix(core): Typing in auth Aug 23, 2024
@alexanderankin alexanderankin merged commit 66726b6 into testcontainers:main Sep 8, 2024
12 checks passed
alexanderankin pushed a commit that referenced this pull request Sep 8, 2024
Supports:
#305
Related : #691 

```bash
poetry run mypy --config-file pyproject.toml core/testcontainers/core/config.py core/testcontainers/core/utils.py
Success: no issues found in 2 source files
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants