Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Typing in config + utils #692

Merged

Conversation

Tranquility2
Copy link
Contributor

@Tranquility2 Tranquility2 commented Aug 22, 2024

Supports: #305
Related : #691

poetry run mypy --config-file pyproject.toml core/testcontainers/core/config.py core/testcontainers/core/utils.py
Success: no issues found in 2 source files

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2cf5a9f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
core/testcontainers/core/utils.py 66.66% 2 Missing ⚠️
core/testcontainers/core/config.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage        ?   77.19%           
=======================================
  Files           ?       12           
  Lines           ?      605           
  Branches        ?       89           
=======================================
  Hits            ?      467           
  Misses          ?      112           
  Partials        ?       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexanderankin alexanderankin changed the title fix: typing in core config + utils fix(core): typing in config + utils Aug 22, 2024
@Tranquility2 Tranquility2 changed the title fix(core): typing in config + utils fix(core): Typing in config + utils Aug 23, 2024
@Tranquility2
Copy link
Contributor Author

Note: it will be best to introduce #693 first, rebase and align this.

@CarliJoy
Copy link
Contributor

CarliJoy commented Sep 2, 2024

Hi,

it is important that the build package contains a py.typed at least in the testcontainers.core or best in the testcontainers folder.

I don't see this in MR so does not fix #305

@Tranquility2
Copy link
Contributor Author

Hi @CarliJoy #305 is a track not a single PR (in my option) this PR helps us get closer to the Goal described on #305.
It never claimed to fix it the issue, just to support the effort.
Can we agree it a step in the right direction?

@Tranquility2
Copy link
Contributor Author

Just to be clear, there is no (clear) reason not to merge this and after that's done I can continue and work on other parts that needs the typing fixed :)

@alexanderankin alexanderankin merged commit 794a22e into testcontainers:main Sep 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants