Let istanbul generate combined coverage report #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursive globs (`**`) can't be relied upon, since the `globstar` option isn't universally enabled (or even available). Thus, the glob expression must be expanded by the tool itself. Wrapping in single quotes clearly indicates the shell isn't doing the expansion of the globs.
istanbul-combine is no longer necessary, since `istanbul report` does the same thing: jamestalmage/istanbul-combine#2 This change replaces the `istanbul-combine` command with `istanbul report`. By default, it uses `**/coverage.json` as the input (which automatically matches coverage/{unit,safe}/coverage.json). The default output is `coverage/`, which is now left as default for simplicity. Thus the upload script is changed to upload from `coverage/lcov.info` instead of `coverage/combine/lcov.info`. Lastly, the `test:cover` script is split so that its role is strictly to generate the coverage data. The "post"-test:cover script is responsible for generating the report. (post script used directly, rather than adding indirection for a test:cover:report script, since it would rarely be run directly.)
|
LGTM |
jasonkarns
changed the title
jasonkarns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istanbul-combine is no longer necessary, since
istanbul reportdoes thesame thing: jamestalmage/istanbul-combine#2
This change replaces the
istanbul-combinecommand withistanbul report.By default, it uses
**/coverage.jsonas the input (which automaticallymatches coverage/{unit,safe}/coverage.json).
The default output is
coverage/, which is now left as default forsimplicity. Thus the upload script is changed to upload from
coverage/lcov.infoinstead ofcoverage/combine/lcov.info.Lastly, the
test:coverscript is split so that its role is strictly togenerate the coverage data.
The "post"-test:cover script is responsible for generating the report.
(post script used directly, rather than adding indirection for a
test:cover:report script, since it would rarely be run directly.)