Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let istanbul generate combined coverage report #75

Merged
merged 4 commits into from
Dec 19, 2018
Merged

Let istanbul generate combined coverage report #75

merged 4 commits into from
Dec 19, 2018

Commits on Dec 18, 2018

  1. Clarify unexpanded globs 

    Recursive globs (`**`) can't be relied upon, since the `globstar` option
isn't universally enabled (or even available).

Thus, the glob expression must be expanded by the tool itself.
Wrapping in single quotes clearly indicates the shell isn't doing the
expansion of the globs.
    @jasonkarns
    jasonkarns committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    7cd8740 View commit details
    Browse the repository at this point in the history

  2. Let istanbul generate combined coverage report 

    istanbul-combine is no longer necessary, since `istanbul report` does
the same thing: jamestalmage/istanbul-combine#2

This change replaces the `istanbul-combine` command with `istanbul
report`. By default, it uses `**/coverage.json` as the input (which
automatically matches coverage/{unit,safe}/coverage.json).

The default output is `coverage/`, which is now left as default for
simplicity. Thus the upload script is changed to upload from
`coverage/lcov.info` instead of `coverage/combine/lcov.info`.

Lastly, the `test:cover` script is split so that its role is strictly to
generate the coverage data.

The "post"-test:cover script is responsible for generating the report.
(post script used directly, rather than adding indirection for a
test:cover:report script, since it would rarely be run directly.)
    @jasonkarns
    jasonkarns committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    9cb258d View commit details
    Browse the repository at this point in the history

  3. Remove istanbul-combine devDep

    @jasonkarns
    jasonkarns committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    df351a6 View commit details
    Browse the repository at this point in the history

  4. Move appveyor to same dotfile name as other non-essential configs

    @jasonkarns
    jasonkarns committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    6624e87 View commit details
    Browse the repository at this point in the history