Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base-cluster): enable velero servicemonitor if prometheus is enabled #724

Merged
merged 7 commits into from
Jul 31, 2024
Merged

feat(base-cluster): enable velero servicemonitor if prometheus is enabled #724

merged 7 commits into from
Jul 31, 2024

Conversation

tasches
Copy link
Collaborator

@tasches tasches commented Jan 17, 2024 •
edited
Loading

closes #487

@tasches tasches self-assigned this Jan 17, 2024
@tasches tasches mentioned this pull request Jan 17, 2024
Closed
@tasches tasches force-pushed the feat/velero-enable-monitor branch from a25186b to 2cab39a Compare January 17, 2024 14:04
@tasches tasches enabled auto-merge (squash) January 17, 2024 14:05
@marvinWolff
Copy link
Collaborator

This does enable the metrics endpoints, but will the alerts also be generated?
As the endpoints alone will not give us any alerts if a backup fails.

@marvinWolff
Copy link
Collaborator

https://github.com/vmware-tanzu/helm-charts/blob/main/charts/velero/values.yaml#L261

This needs to be set in order for the rules to be created.

@tasches tasches force-pushed the feat/velero-enable-monitor branch 3 times, most recently from c9e7347 to e45c27d Compare February 8, 2024 12:54
@tasches tasches requested a review from cwrau February 8, 2024 12:55
@tasches tasches force-pushed the feat/velero-enable-monitor branch from e45c27d to 873271c Compare February 15, 2024 15:39
cwrau
cwrau previously requested changes Feb 16, 2024
View reviewed changes
charts/base-cluster/templates/backup/velero.yaml Show resolved Hide resolved
charts/base-cluster/templates/backup/velero.yaml Show resolved Hide resolved
charts/base-cluster/templates/backup/velero.yaml Outdated Show resolved Hide resolved
@teutonet-bot
Copy link
Contributor

teutonet-bot commented Feb 16, 2024 •
edited
Loading

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml

charts/base-cluster/ci/rbac-values.yaml has no changes

charts/base-cluster/ci/pagerduty-values.yaml

charts/base-cluster/ci/velero-backupStorageLocations-gen-values.yaml

charts/base-cluster/ci/flux-gitrepositories-gen-values.yaml

charts/base-cluster/ci/imagepullsecrets-values.yaml has no changes

charts/base-cluster/values.yaml has no changes

charts/base-cluster/ci/artifacthub-values.yaml has no changes

charts/base-cluster/ci/disabled-ingress-values.yaml

charts/base-cluster/ci/priorityclasses-values.yaml

charts/base-cluster/ci/deadmansswitch-values.yaml

charts/base-cluster/ci/monitoring-oidc-values.yaml

charts/base-cluster/ci/basic-values.yaml has no changes

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml

charts/base-cluster/ci/limitrange-resourcequota-values.yaml

@tasches
Copy link
Collaborator Author

tasches commented Feb 16, 2024 •
edited
Loading

screenshot from a test deployment. The PrometheusRules are now visible and active
image

@tasches tasches force-pushed the feat/velero-enable-monitor branch from f2705d2 to 505f951 Compare July 10, 2024 13:21
@tasches tasches force-pushed the feat/velero-enable-monitor branch from 505f951 to ab492ab Compare July 30, 2024 11:08
@tasches tasches dismissed cwrau’s stale review July 31, 2024 09:45

fixed. GH did not recognize the changes

@tasches tasches merged commit 4482223 into main Jul 31, 2024
11 of 12 checks passed
@tasches tasches deleted the feat/velero-enable-monitor branch July 31, 2024 09:45
@teutonet-bot teutonet-bot mentioned this pull request Jul 31, 2024
Merged
teutonet-bot added a commit that referenced this pull request Jul 31, 2024
@teutonet-bot @github-actions
chore(main): [bot] release base-cluster:6.6.0 (#1043)
b66e884 
🤖 I have created a release *beep* *boop*
---


##
[6.6.0](base-cluster-v6.5.1...base-cluster-v6.6.0)
(2024-07-31)


### Features

* **base-cluster:** add kdave for deprecated CRD metrics
([#947](#947))
([4609be4](4609be4))
* **base-cluster:** enable velero servicemonitor if prometheus is
enabled
([#724](#724))
([4482223](4482223)),
closes
[#487](#487)


### Bug Fixes

* **base-cluster/kube-janitor:** enable artifacthub-values and correctly
prefix docker.io registry
([#1048](#1048))
([17b9baf](17b9baf))


### Miscellaneous Chores

* **base-cluster:** use template instead of duplicated value
([#1050](#1050))
([4ef2389](4ef2389))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@teutonet-bot teutonet-bot mentioned this pull request Jul 31, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Aug 21, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwrau cwrau cwrau left review comments

@marvinWolff marvinWolff marvinWolff approved these changes

@teutonet-bot teutonet-bot Awaiting requested review from teutonet-bot teutonet-bot is a code owner

Assignees

@tasches tasches

Labels
base-cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[base-cluster] create velero backup monitoring rule
4 participants
@tasches @marvinWolff @teutonet-bot @cwrau