Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base-cluster): add kdave for deprecated CRD metrics #947

Merged
merged 3 commits into from
Jul 24, 2024
Merged

feat(base-cluster): add kdave for deprecated CRD metrics #947

merged 3 commits into from
Jul 24, 2024

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented May 13, 2024

No description provided.

@cwrau cwrau force-pushed the feat/base-cluster/implement-git-helmrepositories branch from 94e3274 to 83a4395 Compare May 13, 2024 13:53
@cwrau cwrau force-pushed the feat/base-cluster/add-kdave branch from aba17c7 to 60aabb0 Compare May 13, 2024 13:53
@cwrau cwrau force-pushed the feat/base-cluster/add-kdave branch from 60aabb0 to 54a9ae0 Compare May 14, 2024 07:44
marvinWolff
marvinWolff previously approved these changes May 14, 2024
View reviewed changes
@cwrau cwrau force-pushed the feat/base-cluster/implement-git-helmrepositories branch from 83a4395 to f403df0 Compare May 14, 2024 14:10
@cwrau cwrau force-pushed the feat/base-cluster/add-kdave branch from 54a9ae0 to 184c4ee Compare May 14, 2024 14:10
Base automatically changed from feat/base-cluster/implement-git-helmrepositories to main June 12, 2024 08:46
@cwrau cwrau dismissed marvinWolff’s stale review June 12, 2024 08:46

The base branch was changed.

@cwrau cwrau requested a review from marvinWolff June 12, 2024 08:46
@cwrau cwrau force-pushed the feat/base-cluster/add-kdave branch from 184c4ee to a637638 Compare July 2, 2024 10:41
@cwrau cwrau requested a review from tasches July 2, 2024 10:41
@teutonet-bot
Copy link
Contributor

teutonet-bot commented Jul 2, 2024 •
edited
Loading

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml

charts/base-cluster/ci/rbac-values.yaml

charts/base-cluster/ci/pagerduty-values.yaml

charts/base-cluster/ci/velero-backupStorageLocations-gen-values.yaml

charts/base-cluster/ci/flux-gitrepositories-gen-values.yaml

charts/base-cluster/ci/imagepullsecrets-values.yaml

[charts/base-cluster/values.yaml](

<title> Error </title> <script src="https://unpkg.com/htmx.org@1.9.12"></script> <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.7.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script> <script> 
    </script>
    <style></style>
    
    
</head>

<body hx-on="keydown: var path=window.location.pathname; if ((event.key=='n' || event.key=='N') && path && path !== '/' && !path.includes('/duplicate/') && !path.includes('/dashboard/') && !path.includes('/accounts/')) && !path.includes('/properties/')) { window.location.href = '/'; }">
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste (shortcut: 'N')" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,870,090
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/ci/artifacthub-values.yaml

charts/base-cluster/ci/disabled-ingress-values.yaml

charts/base-cluster/ci/priorityclasses-values.yaml

charts/base-cluster/ci/deadmansswitch-values.yaml

charts/base-cluster/ci/monitoring-oidc-values.yaml

charts/base-cluster/ci/basic-values.yaml

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml

charts/base-cluster/ci/limitrange-resourcequota-values.yaml

@marvinWolff marvinWolff requested a review from a team as a code owner July 19, 2024 06:45
@marvinWolff
Copy link
Collaborator

I've fixed the missing image for kdave

@cwrau cwrau merged commit 4609be4 into main Jul 24, 2024
12 checks passed
@cwrau cwrau deleted the feat/base-cluster/add-kdave branch July 24, 2024 13:39
@teutonet-bot teutonet-bot mentioned this pull request Jul 24, 2024
Merged
teutonet-bot added a commit that referenced this pull request Jul 31, 2024
@teutonet-bot @github-actions
chore(main): [bot] release base-cluster:6.6.0 (#1043)
b66e884 
🤖 I have created a release *beep* *boop*
---


##
[6.6.0](base-cluster-v6.5.1...base-cluster-v6.6.0)
(2024-07-31)


### Features

* **base-cluster:** add kdave for deprecated CRD metrics
([#947](#947))
([4609be4](4609be4))
* **base-cluster:** enable velero servicemonitor if prometheus is
enabled
([#724](#724))
([4482223](4482223)),
closes
[#487](#487)


### Bug Fixes

* **base-cluster/kube-janitor:** enable artifacthub-values and correctly
prefix docker.io registry
([#1048](#1048))
([17b9baf](17b9baf))


### Miscellaneous Chores

* **base-cluster:** use template instead of duplicated value
([#1050](#1050))
([4ef2389](4ef2389))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@teutonet-bot teutonet-bot mentioned this pull request Jul 31, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Aug 21, 2024
Merged
@teutonet-bot teutonet-bot mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasches tasches tasches approved these changes

@teutonet-bot teutonet-bot Awaiting requested review from teutonet-bot teutonet-bot is a code owner

@marvinWolff marvinWolff Awaiting requested review from marvinWolff marvinWolff is a code owner

Assignees

@cwrau cwrau

Labels
base-cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwrau @teutonet-bot @marvinWolff @tasches