Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar enhacements #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nanoant
Copy link
Member

@nanoant nanoant commented Dec 7, 2015

First 3 commits fix parsing quoted string. Next ones extend grammar. See each commit for details.

Previously quoted string could start anywhere, eg. text=Ain't quoted
Previously very first quote (even escaped one) ended quoted string, eg.:

  quoted='This ain\'t an end yet.'
End either on line end or at comment start ; or # character.
@ChuanyuWang
Copy link

Can anyone merge this request? It causes the wrong highlighting inside VS Code. See Microsoft/vscode#41719

@Tekbr
Copy link

Tekbr commented Jul 9, 2018

-- Sorry for the English, I used Google Translator --
Hello!! @infininight Can you merge request? See the issue mentioned above by @ChuanyuWang

@ChuanyuWang
Copy link

@sorbits May I have your attention here, as this repository wasn't update in the last 3 years. Thanks~

@infininight
Copy link
Member

Will look over this in the coming days. This is one of those annoying languages that has competing specs so I need to look over what is best for the language as an aggregate as I introduce changes. Many of these seem good though at first glance.

@jmiguel-hdez
Copy link

any chance the pull request can be merged?

@diatomicDisaster
Copy link

7 years and this extremely simple fix for a major issue with ini file syntax highlighting still hasn't been merged. Please can this be done ASAP?

@SergeiTravkin
Copy link

Does it make any sense to wait for this PR to be merged? The entire file looks like a string because of a single apostrophe :(

@Jonathan29
Copy link

Is there any progress on this? Will this PR be merged anytime soon? This issue makes whole files very uncomfortable to read or understand.

@TausHaus
Copy link

Bueller...Bueller...
@infininight
@sorbits
@Soryu
@ciaran
@torsten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants