[WIP] Ruby 3.0 keywords argument compatibility #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for all component types.
(shared between the streaming runner and the legacy runner)
|
Closing in favour of #93 (which uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #85 for more context.
When working with Kiba and in particular when defining pipelines and components
initializemethod , it is very frequent to rely on keyword arguments.Ruby 2.7 introduces warnings due upcoming changes in keyword arguments (to prepare for Ruby 3).
When using Ruby 2.8.0-dev, these warnings usually become blocking errors.
This PR (WIP, not ready since more work is needed, but opened to create visibility on this specific topic) introduces preliminary support for keyword arguments.