Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 keyword arguments compatibility (pass two) #93

Merged
merged 9 commits into from
Sep 14, 2020

Conversation

thbar
Copy link
Owner

@thbar thbar commented Sep 14, 2020

This PR fixes Kiba ETL keyword arguments support for Ruby 2.7+ (and replaces #86 which is a previous attempt I wasn't completely happy with). See #85 for initial issue.

This works equally with Ruby 2.7.1 and current Ruby master (2.8.0-dev in rbenv, with ruby -v giving 3.0.0dev).

Decision

Special thanks to @eregon and @mame for their valuable input during the past few months.

I have decided for now to use ruby2_keywords like Rails does, which means:

  • the impact should normally be inexistent for Ruby 2.7 (time will tell how this fares with the final version of Ruby 3).
  • and in a way which doesn't require the ruby2_keywords gem

Relevant literature

@thbar
Copy link
Owner Author

thbar commented Sep 14, 2020

Tested fine on a reasonably complex ETL setup. I'll merge.

@thbar thbar merged commit bf12797 into master Sep 14, 2020
@thbar thbar deleted the ruby-2-7-kwargs-fixes branch September 14, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant