Fixes #26969 - Allow using remote core even if core gem is available #63
Conversation
lib/smart_proxy_dynflow/plugin.rb
Outdated
| # by standalone Dynflow core | ||
| end | ||
| # Ensure the core gem is loaded, if configure NOT to use the external core | ||
| require 'smart_proxy_dynflow_core' if Proxy::Dynflow::Plugin.settings.external_core == false |
There was a problem hiding this comment.
| require 'smart_proxy_dynflow_core' if Proxy::Dynflow::Plugin.settings.external_core == false | |
| require 'smart_proxy_dynflow_core' unless Proxy::Dynflow::Plugin.settings.external_core |
There was a problem hiding this comment.
The thing is I need to distinguish between false and nil. But maybe I'm just overthinking things and this whole three-valued logic is not needed at all
There was a problem hiding this comment.
Since there's duplication in the http_config, should we have a helper? Can we reuse the output of this loading somehow?
There was a problem hiding this comment.
Btw. would this work without Debian packaging/installer changes to explicitly disable the loading?
There was a problem hiding this comment.
Yes, by default the value will be unset. This will make the proxy try loading the core, use it if available and fallback to external core otherwise.
adamruzicka
force-pushed
the
external-core
branch
from
6e49a83
to
9a8fe75
Compare
The behavior can be configured using the external_core key in the settings. If unset, the behavior will remain the same, eg. use internal core if available, fallback to external core otherwise. Setting it to true will force the proxy to always use an external core. Setting it to false will make the proxy try to always use the internal core and disable the feature if it is not available.
adamruzicka
force-pushed
the
external-core
branch
from
9a8fe75
to
8810ce7
Compare
|
smart_proxy_dynflow 0.2.3 released to rubygems and packaging PRs are theforeman/foreman-packaging#3849 and theforeman/foreman-packaging#3850 |
The behavior can be configured using the
external_corekey in the settings.If unset, the behavior will remain the same, eg. use internal core if available,
fallback to external core otherwise. Setting it to
truewill force the proxy toalways use an external core. Setting it to
falsewill make the proxy try toalways use the internal core and disable the feature if it is not available.