Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for external Dynflow core #512

Merged
merged 5 commits into from
Jul 18, 2019
Merged

Add support for external Dynflow core #512

merged 5 commits into from
Jul 18, 2019

Conversation

adamruzicka
Copy link
Contributor

this option is being introduced in theforeman/smart_proxy_dynflow#63

ekohl
ekohl reviewed Jun 10, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently this is only supported on EL but would it make sense to implement this on Debian as well? Doesn't have to be the same PR, but if we have the right packages it should work and closer align the platforms.

manifests/plugin/dynflow.pp Outdated Show resolved Hide resolved
@adamruzicka
Copy link
Contributor Author

I'm currently looking it. I most likely won't push it into this PR, but having all the platforms unified somewhere down the road would be nice.

@iNecas
Copy link
Member

iNecas commented Jun 10, 2019

In that case I guess we need to have the external_core set only for el-based systems.

@adamruzicka
Copy link
Contributor Author

That makes sense. is that a thing which needs to be done here or should it go to installer/scenarios/somewhere?

@iNecas
Copy link
Member

iNecas commented Jun 11, 2019 •
edited
Loading

If possible to do this changes in a way that they would work with the old installer and it would not be too much of a hassle, I'm for doing the changes changes here (was thinking I was replying different PR.

For this question, 👍 for implementing the check here.

iNecas
iNecas approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@iNecas iNecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The dependent changes were merged in smart_proxy_dynflow and new release has been made. Ok with with getting this in as well

@adamruzicka adamruzicka mentioned this pull request Jun 26, 2019
Closed
ekohl
ekohl approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the wording in comments could be improved.

templates/plugin/dynflow.yml.erb Outdated Show resolved Hide resolved
templates/plugin/dynflow.yml.erb Outdated Show resolved Hide resolved
@adamruzicka @ekohl
Apply suggestions from code review
5d933bb 
Co-Authored-By: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@ekohl ekohl merged commit 5bde9c7 into theforeman:master Jul 18, 2019
@ekohl ekohl added this to the 12.0.0 milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@iNecas iNecas iNecas approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@adamruzicka @iNecas @ekohl @theforeman-bot