This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
bug: fix momentjs dependency #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit fixes the breaking changes caused by `momentjs` by adding a resolution to the `latest` images. `next` images are already fixed upstream. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/fix-latest
branch
from
89b0e91 to
0b5a2a7
Compare
|
@marcdumais-work @marechal-p I think we should remove go from our full image and |
paul-marechal
approved these changes
May 6, 2020
|
@marcdumais-work are you fine if the pull-request is merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #354
The following pull-request fixes the breaking changes caused by momentjs which ultimately results in the main-menu not being rendered successfully. The fix includes adding
resolutionsto thelatestimages only sincenextare fixed by the upstream change: eclipse-theia/theia#7727How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com