Add 'theia-widget-noInfo' css class to fix message inconsistencies #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
the
ui/ux
vince-fugnitto
force-pushed
the
vf/GH-5716
branch
2 times, most recently
from
2b7f8a7 to
93faf44
Compare
Fixes #5716 - fixed the inconsistent padding present in the `outline`, `call-hierarchy` and `problems` view when no information is present. - added a new `widget.css` file which will be used to describe widget specific styling - added the new css class `theia-widget-noInfo` used for widget messages Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/GH-5716
branch
from
93faf44 to
248f9ea
Compare
jbicker
approved these changes
Jul 18, 2019
|
Thank you @jbicker ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5716
Description
outline,call-hierarchyandproblemsview when no information is present.widget.cssfile which will be used to describe widget specific stylingtheia-widget-noInfoused for widget messagesBefore
After
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com