Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all hardcoded font sizes with replacing them on em. #723

Closed
wants to merge 20 commits into from

Conversation

ivan-nginx
Copy link
Member

Refactoring of #689 pull.

@stevenjoezhang
Copy link
Contributor

px is not only used in font-size, need to do more tests if change the unit to em (especially on mobile).

@ivan-nginx
Copy link
Member Author

I right now worked with this PR. Wait for pushes...

@ivan-nginx
Copy link
Member Author

What are u doing?

@stevenjoezhang
Copy link
Contributor

I found two styl files have almost the same content, so I deleted one of them in #724 ... this caused a merge conflict so I resolved it ... run git pull should work fine

@ivan-nginx
Copy link
Member Author

Please, don't touch this pull. I'm working with him and u make pushes to my pull & branch.

@ivan-nginx ivan-nginx closed this Mar 22, 2019
@stevenjoezhang
Copy link
Contributor

Superseded by #1005, #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants