Merge pull request #171 from Aquafina-water-bottle/126_noeval_handlebars

Fix Handlebars not working on Firefox due to eval
themoeway · Jun 10, 2023 · 145628c · 145628c
2 parents 8bf8739 + 17b938a
commit 145628c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 30 deletions.
diff --git a/ext/js/templates/sandbox/template-renderer.js b/ext/js/templates/sandbox/template-renderer.js
@@ -18,6 +18,7 @@
 
 /* global
  * Handlebars
+ * handlebarsCompileFnName
  */
 
 class TemplateRenderer {
@@ -83,7 +84,7 @@ class TemplateRenderer {
         let instance = cache.get(template);
         if (typeof instance === 'undefined') {
             this._updateCacheSize(this._cacheMaxSize - 1);
-            instance = Handlebars.compile(template);
+            instance = Handlebars[handlebarsCompileFnName](template);
             cache.set(template, instance);
         }