Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Handlebars not working on Firefox due to eval #171

Merged

Conversation

Aquafina-water-bottle
Copy link

@Aquafina-water-bottle Aquafina-water-bottle commented Jun 9, 2023

Using Kibana's no-eval handlebars, we're able to pretty much drop-in replace Handlebars with a version that doesn't use eval. Build instructions for the new minified file can be found here: https://github.com/Aquafina-water-bottle/handlebars-noeval

Fixes #126.

Tested on both Chromium and Firefox.

NOTE: This is a bandaid fix. We likely want to look into a different solution that simply does not use handlebars in the future.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Collaborator

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find. LGTM. I do worry about the minimized code from a security perspective and wonder if we can integrate it into CI better or somehow generate provenance.

@djahandarie djahandarie merged commit 145628c into themoeway:master Jun 10, 2023
@Aquafina-water-bottle Aquafina-water-bottle deleted the 126_noeval_handlebars branch June 10, 2023 01:42
@djahandarie djahandarie added the kind/bug The issue or PR is regarding a bug label Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Firefox) Handlebars no longer work (call to Function() blocked by CSP)
2 participants