add source and target language dictionary metadata #891
Conversation
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
StefanVukovic99
added
kind/enhancement
| @@ -47,6 +47,14 @@ | |||
| "type": "string", | |||
| "description": "Attribution information for the dictionary data." | |||
| }, | |||
| "sourceLanguage": { | |||
| "type": "string", | |||
| "description": "Language of the terms in the dictionary." | |||
There was a problem hiding this comment.
iso format or does that not matter?
There was a problem hiding this comment.
I considered a pattern like ^[a-z]{2,3}(-[A-Z]{2})?$, but I haven't been able to find a perfect one.
Or we could do a simple pattern with all our currently supported languages like en|de|fa|fi..., but that's another thing to tweak every time a new language is added.
Or use this https://gist.github.com/konsorten-michael/094f898c3a2847c642a920f7c6f4f575
There was a problem hiding this comment.
Let's use the gist? People can submit issues if something else comes up. If we want to support all languages handlebars i feel it's important to enforce all the same languages use the same string for source language
There was a problem hiding this comment.
I'll throw the gist in, just wanna note that it contains ISO 639-1 codes, we might need to add to that over time for languages that are only in 639-2 or 3, e.g. we have grc as an option in the dropdown.
| "isoLanguageCode": { | ||
| "type": "string", | ||
| "description": "ISO language code (ISO 639-1 where possible, ISO 639-3 otherwise).", | ||
| "pattern": "^(aa|ab|ae|af|ak|am|an|ar|as|av|ay|az|az|ba|be|bg|bh|bi|bm|bn|bo|br|bs|ca|ce|ch|co|cr|cs|cu|cv|cy|da|de|dv|dz|ee|el|en|eo|es|et|eu|fa|ff|fi|fj|fo|fr|fy|ga|gd|gl|gn|grc|gu|gv|ha|he|hi|ho|hr|ht|hu|hy|hz|ia|id|ie|ig|ii|ik|io|is|it|iu|ja|jv|ka|kg|ki|kj|kk|kl|km|kn|ko|kr|ks|ku|kv|kw|ky|la|lb|lg|li|ln|lo|lt|lu|lv|mg|mh|mi|mk|ml|mn|mr|ms|mt|my|na|nb|nd|ne|ng|nl|nn|no|nr|nv|ny|oc|oj|om|or|os|pa|pi|pl|ps|pt|qu|rm|rn|ro|ru|rw|sa|sc|sd|se|sg|si|sk|sl|sm|sn|so|sq|sr|ss|st|su|sv|sw|ta|te|tg|th|ti|tk|tl|tn|to|tr|ts|tt|tw|ty|ug|uk|ur|uz|ve|vi|vo|wa|wo|xh|yi|yo|za|zh|zu)$" |
There was a problem hiding this comment.
This could also be an enum, but i suppose it's fine either way
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This is just displaying them like the rest of the metadata, but I think it may also be useful in the future for