-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add source and target language dictionary metadata #891
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,13 @@ | ||
{ | ||
"$id": "dictionaryIndex", | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"definitions": { | ||
"isoLanguageCode": { | ||
"type": "string", | ||
"description": "ISO language code (ISO 639-1 where possible, ISO 639-3 otherwise).", | ||
"pattern": "^(aa|ab|ae|af|ak|am|an|ar|as|av|ay|az|az|ba|be|bg|bh|bi|bm|bn|bo|br|bs|ca|ce|ch|co|cr|cs|cu|cv|cy|da|de|dv|dz|ee|el|en|eo|es|et|eu|fa|ff|fi|fj|fo|fr|fy|ga|gd|gl|gn|grc|gu|gv|ha|he|hi|ho|hr|ht|hu|hy|hz|ia|id|ie|ig|ii|ik|io|is|it|iu|ja|jv|ka|kg|ki|kj|kk|kl|km|kn|ko|kr|ks|ku|kv|kw|ky|la|lb|lg|li|ln|lo|lt|lu|lv|mg|mh|mi|mk|ml|mn|mr|ms|mt|my|na|nb|nd|ne|ng|nl|nn|no|nr|nv|ny|oc|oj|om|or|os|pa|pi|pl|ps|pt|qu|rm|rn|ro|ru|rw|sa|sc|sd|se|sg|si|sk|sl|sm|sn|so|sq|sr|ss|st|su|sv|sw|ta|te|tg|th|ti|tk|tl|tn|to|tr|ts|tt|tw|ty|ug|uk|ur|uz|ve|vi|vo|wa|wo|xh|yi|yo|za|zh|zu)$" | ||
} | ||
}, | ||
"type": "object", | ||
"description": "Index file containing information about the data contained in the dictionary.", | ||
"required": [ | ||
|
@@ -47,6 +54,14 @@ | |
"type": "string", | ||
"description": "Attribution information for the dictionary data." | ||
}, | ||
"sourceLanguage": { | ||
"$ref": "#/definitions/isoLanguageCode", | ||
"description": "Language of the terms in the dictionary." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. iso format or does that not matter? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I considered a pattern like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's use the gist? People can submit issues if something else comes up. If we want to support all languages handlebars i feel it's important to enforce all the same languages use the same string for source language There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll throw the gist in, just wanna note that it contains ISO 639-1 codes, we might need to add to that over time for languages that are only in 639-2 or 3, e.g. we have grc as an option in the dropdown. |
||
}, | ||
"targetLanguage": { | ||
"$ref": "#/definitions/isoLanguageCode", | ||
"description": "Main language of the definitions in the dictionary." | ||
jamesmaa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
"frequencyMode": { | ||
"type": "string", | ||
"enum": ["occurrence-based", "rank-based"] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could also be an enum, but i suppose it's fine either way