Allow override of domains and whitelist in rules #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah woops, more conflicts 🙂, I'll get this updated |
…nto lozlow/master
This removes the chance for the _default_ (no rule applied) case to overlap with a user-specified rule
lozlow
changed the title
|
This is ready for review, thanks! |
|
@lozlow Looks like we worked this one simultaneously. Would you mind to have a look at #133 and see what you think? My implementation is slightly different. It combines address/domain whitelists into one field, and respects the MatchWhitelistOrDomain property instead of having the rule override the global config entirely |
|
+1 for this. |
|
Hi, this looks awesome, thank you so much! I've rebased and added some minor tweaks in #169 - does that look to you? |
|
Merged in #169 - thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the work of mathcantin in #63
Closes #57
Closes #63