Feature/whitelist domain in rules #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mseddon#63, adding support for the matchWhitelistOrDomain flag
Note: logout endpoint does not work yet. When allowed by a rule whitelist, the AuthHandler intercepts the request before the logout handler
When called internally from ValidateEmail, it was inconvenient to get the tfa.Rule containing the whitelist without modifying the signature. Implemented in the server, it's just another standalone validation This change also avoids the need to have an ambiguous Domain at both the config and rule levels
|
+1 for this. |
|
Thank you for this, there's been a few stabs at this and I'm hoping to merge #169 this week, please let me know if it's missing anything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #63
which accepts either an email address or domain