Unit-details-editor Componet Review #565
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ontrack Component review
Team Member Name
Xin Huang | 218161625
Component Name
UnitDetailsEditor Component
Files in this Component
unit-details-editor.coffee
unit-details-editor.tpl.html
Component purpose
The
unit-details-editor
component is responsible for editing the basic details of a unit. This includes attributes such as the unit name, code, start and end dates, associated teaching periods, and Docker images for automated task assessment. The component provides an interface for instructors to configure these details conveniently.Screenshots:
Original (PDF):
Component Functions
The unit-details-editor component allows users to:
Interaction with other components
Interaction with newUnitService:
Output: saveUnitEvent event, triggered when the unit is saved.
Interaction with newTeachingPeriodService:
Output: teachingPeriodSelected event, triggered when the user selects a teaching period.
Interaction with TaskSubmission:
Output: dockerImages data, providing a list of available Docker images.
Interaction with DoubtfireConstants:
Output: Configuration constants IsOverseerEnabled and ExternalName, used for controlling functionality and displaying the external name.
Migration Steps:
I will be following
doubtfire-web's Migration Guide
Analyze Existing Component:
Setup Angular Environment:
Create Angular Component:
Integrate Services:
newUnitService
,newTeachingPeriodService
,TaskSubmission
,DoubtfireConstants
into the new Angular component.Downgrade Component:
UpgradeModule
to downgrade the Angular component for use in the AngularJS app.Testing:
Component Review Checklist
Ability to collect details from the user
Succeeds when data is valid
Handles errors
Created unit is shown on success