Expose EmberCLI generated index.html #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby support ------------ According to [these release notes][1.9.3-eol], Ruby versions prior to `2.0.x` has been end-of-lifed. Additionally, this codebase makes use of [(required) keyword arguments][kwargs]. From `ember-cli-rails@0.4.0` and on, we will no longer support versions of Ruby prior to `2.1.0`. To use `ember-cli-rails` with older versions of Ruby, try the `0.3.x` series. [kwargs]: https://robots.thoughtbot.com/ruby-2-keyword-arguments [1.9.3-eol]: https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/ Rails support ------------- According to the [Rails Maintenance Policy][version-policy], Rails versions prior to `3.2.x` have been end-of-lifed. Additionally, the `4.0.x` series no longer receives bug fixes of any sort. From `ember-cli-rails@0.4.0` and on, we will no longer support versions of Rails prior to `3.2.0`, nor will we support the `4.0.x` series of releases. To use `ember-cli-rails` with older versions of Rails, try the `0.3.x` series. [version-policy]: http://guides.rubyonrails.org/maintenance_policy.html
| end | ||
|
|
||
| "#{ember_path} build #{watch} --environment #{environment} --output-path #{dist_path} #{log_pipe}" | ||
| "#{ember_path} build #{watch_flag} --environment #{environment} --output-path #{dist_path} #{log_pipe}" |
| def initialize(options) | ||
| @app = options.fetch(:app) | ||
| @sprockets = options.fetch(:sprockets) | ||
| def initialize(app:, sprockets:) |
There was a problem hiding this comment.
@seanpdoyle Can you explain this syntax? I've never seen arguments with colons like that
There was a problem hiding this comment.
They're required keyword arguments.
This PR is also related.
|
This is an accidental duplicate of #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220.
Exposes new public methods for
EmberCLI::App:#index_html- return the EmebrCLI generatedindex.htmlstring#application_assets- return the EmberCLI exposes app assets#vendor_assets- return the EmberCLI exposes vendor assetsExposes new Rails helper:
include_ember_index_html- Renders theindex.htmlinline.Replaces EmberCLI asset paths with Sprockets asset paths