Drop Support for Ruby < 2.1.0 & Rails < 3.2.0 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| "#{ember_path} build #{watch} --environment #{environment} --output-path #{dist_path} #{log_pipe}" | ||
| "#{ember_path} build #{watch_flag} --environment #{environment} --output-path #{dist_path} #{log_pipe}" |
seanpdoyle
force-pushed
the
sd-ruby-versions
branch
2 times, most recently
from
de92607
to
b757a14
Compare
| end | ||
|
|
||
| "#{ember_path} build #{watch} --environment #{environment} --output-path #{dist_path} #{log_pipe}" | ||
| "#{ember_path} build #{watch_flag} --environment #{environment} --output-path #{dist_path} #{log_pipe}" |
|
👍! 🚢 |
seanpdoyle
force-pushed
the
sd-ruby-versions
branch
from
cfcf525
to
27828c2
Compare
| From `ember-cli-rails@0.4.0` and on, we will no longer support versions of Ruby | ||
| prior to `2.1.0`. | ||
|
|
||
| To use `ember-cli-rails` with older versions of Ruby, try the `0.3.x` series. |
There was a problem hiding this comment.
I'm not sure I would mention this at all. This is a pre-1.0 project. Just let it be that you need to use the new versions.
|
LGTM |
Ruby support ------------ According to [these release notes][1.9.3-eol], Ruby versions prior to `2.0.x` has been end-of-lifed. Additionally, this codebase makes use of [(required) keyword arguments][kwargs]. From `ember-cli-rails@0.4.0` and on, we will no longer support versions of Ruby prior to `2.1.0`. To use `ember-cli-rails` with older versions of Ruby, try the `0.3.x` series. [kwargs]: https://robots.thoughtbot.com/ruby-2-keyword-arguments [1.9.3-eol]: https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/ Rails support ------------- According to the [Rails Maintenance Policy][version-policy], Rails versions prior to `3.2.x` have been end-of-lifed. Additionally, the `4.0.x` series no longer receives bug fixes of any sort. From `ember-cli-rails@0.4.0` and on, we will no longer support versions of Rails prior to `3.2.0`, nor will we support the `4.0.x` series of releases. To use `ember-cli-rails` with older versions of Rails, try the `0.3.x` series. [version-policy]: http://guides.rubyonrails.org/maintenance_policy.html
seanpdoyle
force-pushed
the
sd-ruby-versions
branch
from
27828c2
to
0ed5aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby support
According to these release notes, Ruby versions prior to
2.0.xhas been end-of-lifed.
Additionally, this codebase makes use of (required) keyword arguments.
From
ember-cli-rails@0.4.0and on, we will no longer support versions of Rubyprior to
2.1.0.To use
ember-cli-railswith older versions of Ruby, try the0.3.xseries.Rails support
According to the Rails Maintenance Policy, Rails versions
prior to
3.2.xhave been end-of-lifed. Additionally, the4.0.xseries nolonger receives bug fixes of any sort.
From
ember-cli-rails@0.4.0and on, we will no longer support versions of Railsprior to
3.2.0, nor will we support the4.0.xseries of releases.To use
ember-cli-railswith older versions of Rails, try the0.3.xseries.