Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding expose application's docs #610

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Conversation

maayarosama
Copy link
Contributor

Description

Adding expose docs

Related Issues

Copy link
Contributor

@Mik-TF Mik-TF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Added the file in summary.md so we can access it on the manual.

Note: We should only merge the PR once the app is at least on devnet.

@khaledyoussef24 khaledyoussef24 merged commit baa3b49 into development Aug 11, 2024
@khaledyoussef24 khaledyoussef24 deleted the development_expose branch August 11, 2024 10:34
@khaledyoussef24
Copy link
Contributor

shall we add images from the manage domains also ?

@Mik-TF
Copy link
Contributor

Mik-TF commented Aug 11, 2024

@maayarosama What do you think of Khaled's proposition? We can make a new PR to add manage domain pictures.

@maayarosama
Copy link
Contributor Author

@maayarosama What do you think of Khaled's proposition? We can make a new PR to add manage domain pictures.

There's no manage domains feature in expose solution, it's in full vm solution. I suggest adding the picture to the fullvm docs

@Mik-TF
Copy link
Contributor

Mik-TF commented Aug 11, 2024

We have a section showing how to manage the domains, which is valid for both micro and full VMs: https://www.manual.dev.grid.tf/documentation/dashboard/solutions/add_domain.html

@khaledyoussef24 I think this is sufficient. What do you think?

@khaledyoussef24
Copy link
Contributor

Yes, this is more than enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants