Adding expose application #3215

maayarosama · 2024-08-04T15:39:10Z

Description

Adding Domains solution to the dashboard

Related Issues

Expose solution #3178

Documentation PR

Checklist

Mik-TF · 2024-08-07T16:01:54Z

Note: I adjusted 2 basic texts on expose. To say: Expose allows... instead of Expose application allows...

Just like we say, e.g., Gitea provides... instead of Gitea application provides...

Commit: 46b4c53

Mik-TF · 2024-08-07T17:47:00Z

@maayarosama Sorry for the direct commit. I understand that I should have made a review/proposition. Will use reviews in the future! Great work btw :)

amiraabouhadid

please add a validation that ip should not be local host

AhmedHanafy725 · 2024-08-08T12:51:55Z

packages/playground/src/weblets/tf_expose.vue

+      <SelectSolutionFlavor
+        v-model="solution"
+        :small="{ cpu: 1, memory: 2, disk: 50 }"
+        :medium="{ cpu: 2, memory: 4, disk: 100 }"
+      />


this solution shouldn't contain a vm, it should be only a gateway workload

AhmedHanafy725 · 2024-08-08T13:32:49Z

packages/playground/src/weblets/tf_expose.vue

+        tooltip="User's machine's public IP , It could be Mycelium IP, Yggdrasil IP, or a public IP (IPv4 or IPv6)."
+      >
+        <input-validator
+          :value="ip"
+          :rules="[validators.required('Public IP is required.'), validators.isIP('Public IP is not valid.')]"
+          #="{ props }"
+        >
+          <v-text-field label="Public IP" v-model="ip" v-bind="props" />


it doesn't have to be a public ip. Mycelium and Yggdarsil are not public. let's rename it to IP

AhmedHanafy725 · 2024-08-08T13:38:22Z

packages/playground/src/weblets/tf_expose.vue

+
+    await deployGatewayName(grid, selectionDetails.value.domain, {
+      subdomain: subdomain.value,
+      ip: ip.value,


the ipv4 here will work as it will be in the format http://{ip}:{port}
but in case of the ipv6, it won't work as it should be http://[{ip}]:{port}

feat: Add support in deployment list to handle domains

0oM4R

I can't delete a created domain instance,

Screencast.from.2024-08-19.10-58-34.webm

AhmedHanafy725 · 2024-08-19T17:14:06Z

packages/playground/public/info/domains.md

+title: Domains
+---
+
+Domains allows users to securely expose servers hosted on local machines or VMs to the public internet. Users are required to specify the machine's IP, which can be a Mycelium IP, Yggdrasil IP, or a public IP (IPv4 or IPv6). For more details, check the [Domains documentation](https://www.manual.grid.tf/documentation/dashboard/solutions/expose.html).


please update the documentation file name in info_grid repo.

AhmedHanafy725 · 2024-08-19T17:16:48Z

packages/playground/src/constants/deployment_list.ts

do we need the changes in this file?

packages/playground/src/utils/delete_deployment.ts

packages/playground/src/weblets/tf_domains.vue

AhmedHanafy725 · 2024-08-19T17:51:55Z

please fix the failing build

…Contract method

0oM4R · 2024-08-20T07:54:16Z

still exists

0oM4R · 2024-08-20T07:57:46Z

I tried to use custom domain, but i found this after deployment succeed

deployment data:

- chore: Update default value for 'documentScrollend' to 'false' as 'true' casuing it to not working fine in most cases - fix: Domains solution now show data after deploying

0oM4R · 2024-08-20T10:07:28Z

I tried to use custom domain, but i found this after deployment succeed

deployment data:

Screencast.from.2024-08-20.13-06-55.webm

0oM4R

the behavior of deleting the deployments is not consist with other solutions.

Screencast.from.2024-08-20.13-12-44.webm

Mik-TF · 2024-08-20T14:05:50Z

Some text suggestions:

Alternative: not points but point

This should be two sentences (missing a dot). Proposition: "Machine's IP: It could be a Mycelium IP, an Yggdrasil IP or a public IP (IPV4 or IPv6)"

General notes: some of those details button have the texts ending with a dot and others don't. We might want to generalize the presenting (ending or not with a dot for all).

Proposition for below: "The port used..."
"Selecting Custom Domain sets the subdomain as the gateway name"

0oM4R · 2024-08-22T12:42:24Z

why do we need the sshkey field here is it used ?

0oM4R · 2024-08-25T09:33:50Z

please add tls passthrough option field

- chore: removed unused ssh

0oM4R

Thank you both for the great work

0oM4R · 2024-08-26T13:56:00Z

packages/playground/src/constants/deployment_list.ts

@@ -186,4 +191,8 @@ export const deploymentListEnvironments = {
    SSH_KEY: _ssh,
    NODE_PILOT_HOSTNAME: "Node Pilot Hostname",
  },
+  domains: {
+    SSH_KEY: _ssh,


please remove this, i think we don't need it

amiraabouhadid

why can't i toggle the TLS switch ?
https://www.loom.com/share/8f66f5c0898246dfab389c4b7a2687b4?sid=80b3e425-10a8-4aa6-8523-093e98f71d07

amiraabouhadid · 2024-08-28T13:29:46Z

why can't i toggle the TLS switch ? https://www.loom.com/share/8f66f5c0898246dfab389c4b7a2687b4?sid=80b3e425-10a8-4aa6-8523-093e98f71d07

my bad didn't realize this switch is read only

maayarosama added 3 commits August 4, 2024 18:35

Adding expose application

bd2afab

Removing selection details output

9fd10ee

Adding validations to ip field and expose icon

8c9f89e

maayarosama marked this pull request as ready for review August 6, 2024 10:52

maayarosama requested review from AhmedHanafy725, zaelgohary, MohamedElmdary, Mahmoud-Emad, amiraabouhadid, AlaaElattar, 0oM4R, mohamedamer453 and samaradel as code owners August 6, 2024 10:52

adjused expose descriptions

46b4c53

amiraabouhadid reviewed Aug 8, 2024

View reviewed changes

maayarosama marked this pull request as draft August 8, 2024 13:26

AhmedHanafy725 requested changes Aug 8, 2024

View reviewed changes

maayarosama and others added 7 commits August 12, 2024 22:10

Merge branch 'development' into development_expose_application

b2af973

Removing vm deployment

d52d90a

Makint network optional in gateway

b8d037d

Changing expose to domains and fixing open dialouge feature

44e4b97

Merge branch 'development' into development_expose_application

845e7ea

feat: Add support for listing domains(gateways)

cf93d08

feat: Add support in deployment list to handle domains

Fixing deployment dialouge

c7f2acd

maayarosama marked this pull request as ready for review August 18, 2024 12:28

maayarosama requested review from amiraabouhadid and AhmedHanafy725 August 18, 2024 12:28

0oM4R reviewed Aug 19, 2024

View reviewed changes

AhmedHanafy725 reviewed Aug 19, 2024

View reviewed changes

Fix build error, adding validate subdomain and renaming deleteGateway…

699eac4

…Contract method

maayarosama requested a review from AhmedHanafy725 August 19, 2024 20:25

MohamedElmdary assigned MohamedElmdary and maayarosama Aug 20, 2024

- style: Capitalize state/health of gateway

81e3152

- chore: Update default value for 'documentScrollend' to 'false' as 'true' casuing it to not working fine in most cases - fix: Domains solution now show data after deploying

0oM4R requested changes Aug 20, 2024

View reviewed changes

MohamedElmdary added 2 commits August 21, 2024 12:44

chore: applying typos suggestions

fb920ad

fix: Data wasn't correctly picked when using custom domain

21e47bc

- feat: Add support for tls passthrough

2b402b7

- chore: removed unused ssh

0oM4R approved these changes Aug 26, 2024

View reviewed changes

0oM4R reviewed Aug 26, 2024

View reviewed changes

MohamedElmdary added 2 commits August 27, 2024 10:36

chore: Remove unused env variables

ac90473

fix: build failed due to removing env which being used somewhere in code

f7a6fe6

0oM4R approved these changes Aug 27, 2024

View reviewed changes

amiraabouhadid reviewed Aug 27, 2024

View reviewed changes

amiraabouhadid self-requested a review August 28, 2024 13:28

amiraabouhadid approved these changes Aug 28, 2024

View reviewed changes

AhmedHanafy725 approved these changes Aug 28, 2024

View reviewed changes

MohamedElmdary merged commit 448a213 into development Aug 28, 2024
10 checks passed

MohamedElmdary deleted the development_expose_application branch August 28, 2024 13:37

xmonader added this to the 2.6.0 milestone Sep 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding expose application #3215

Adding expose application #3215

maayarosama commented Aug 4, 2024 •

edited

Loading

Mik-TF commented Aug 7, 2024 •

edited

Loading

Mik-TF commented Aug 7, 2024

amiraabouhadid left a comment

AhmedHanafy725 Aug 8, 2024

AhmedHanafy725 Aug 8, 2024

AhmedHanafy725 Aug 8, 2024

0oM4R left a comment •

edited

Loading

AhmedHanafy725 Aug 19, 2024

AhmedHanafy725 Aug 19, 2024

AhmedHanafy725 commented Aug 19, 2024

0oM4R commented Aug 20, 2024

0oM4R commented Aug 20, 2024

0oM4R commented Aug 20, 2024

0oM4R left a comment

Mik-TF commented Aug 20, 2024 •

edited

Loading

0oM4R commented Aug 22, 2024

0oM4R commented Aug 25, 2024 •

edited

Loading

0oM4R left a comment

0oM4R Aug 26, 2024

amiraabouhadid left a comment

amiraabouhadid commented Aug 28, 2024

Adding expose application #3215

Adding expose application #3215

Conversation

maayarosama commented Aug 4, 2024 • edited Loading

Description

Related Issues

Documentation PR

Checklist

Mik-TF commented Aug 7, 2024 • edited Loading

Mik-TF commented Aug 7, 2024

amiraabouhadid left a comment

Choose a reason for hiding this comment

AhmedHanafy725 Aug 8, 2024

Choose a reason for hiding this comment

AhmedHanafy725 Aug 8, 2024

Choose a reason for hiding this comment

AhmedHanafy725 Aug 8, 2024

Choose a reason for hiding this comment

0oM4R left a comment • edited Loading

Choose a reason for hiding this comment

AhmedHanafy725 Aug 19, 2024

Choose a reason for hiding this comment

AhmedHanafy725 Aug 19, 2024

Choose a reason for hiding this comment

AhmedHanafy725 commented Aug 19, 2024

0oM4R commented Aug 20, 2024

0oM4R commented Aug 20, 2024

0oM4R commented Aug 20, 2024

0oM4R left a comment

Choose a reason for hiding this comment

Mik-TF commented Aug 20, 2024 • edited Loading

0oM4R commented Aug 22, 2024

0oM4R commented Aug 25, 2024 • edited Loading

0oM4R left a comment

Choose a reason for hiding this comment

0oM4R Aug 26, 2024

Choose a reason for hiding this comment

amiraabouhadid left a comment

Choose a reason for hiding this comment

amiraabouhadid commented Aug 28, 2024

maayarosama commented Aug 4, 2024 •

edited

Loading

Mik-TF commented Aug 7, 2024 •

edited

Loading

0oM4R left a comment •

edited

Loading

Mik-TF commented Aug 20, 2024 •

edited

Loading

0oM4R commented Aug 25, 2024 •

edited

Loading