Updating expose docs to domains docs #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maayarosama
requested review from
AhmedHanafy725,
scottyeager,
Mik-TF,
xmonader,
ramezsaeed and
A-Harby
as code owners
5 tasks
|
@maayarosama looks good in general. Some things are missing. You can check this PR #628 If you agree with my changes I'll merge the PR into your current branch (development_domains), then we can merge this PR. |
fixed some details in development_domains
Mik-TF
approved these changes
Aug 20, 2024
|
LGTM. I approved the PR. As discussed with @xmonader, we will be able to merge this PR to manual.dev.grid.tf (info_grid dev branch) when the Domains app is added on the dashboard devnet (in this PR: threefoldtech/tfgrid-sdk-ts#3178) |
|
I just want to make sure with the dev team that the dashboard will soon be updated on devnet to take into account Domains app. Otherwise, we would need to wait before releasing the guides on manual.dev.grid.tf (dashboard.dev.grid.tf must correspond with manual.dev.grid.tf) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating expose docs to domains docs
Related Issues