Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete twin is not allowed #586

Merged
merged 9 commits into from
Jan 31, 2023
Merged

feat: delete twin is not allowed #586

merged 9 commits into from
Jan 31, 2023

Conversation

renauter
Copy link
Collaborator

renauter
renauter commented Jan 20, 2023
View reviewed changes
substrate-node/pallets/pallet-smart-contract/src/tests.rs Outdated
// let contract_id = contracts_to_bill_at_block[0];

// // delete twin to make the billing fail
// assert_ok!(TfgridModule::delete_twin(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented this test because the delete_twin() extrinsic is now deprecated and test need update.
Can we adapt or do we remove the test?

@brandonpille @DylanVerstraete

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove. That test was added for if the offchain worker billing failed it would try to bill again in the next block.

Copy link
Collaborator Author

@renauter renauter Jan 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so no other way to make the offchain worker billing fail and maintain test ?
If not, I ll remove

@renauter renauter marked this pull request as ready for review January 20, 2023 15:37
@renauter renauter requested review from brandonpille and removed request for robvanmieghem and LeeSmet January 20, 2023 15:37
@DylanVerstraete
Copy link
Contributor

Since the new metadata (v14) is self-describing, I'd rather remove the call as a whole.

@renauter
Copy link
Collaborator Author

Since the new metadata (v14) is self-describing, I'd rather remove the call as a whole.

Ok
There also 2 other deprecated calls

Should I remove them also ?

@DylanVerstraete
Copy link
Contributor

Sure, just make sure the call indexes are still the same for other extrinsics

@renauter
Copy link
Collaborator Author

Sure, just make sure the call indexes are still the same for other extrinsics

Ok, so I guess pulling an index is not a problem ;)

brandonpille
brandonpille approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice work.

@DylanVerstraete DylanVerstraete merged commit abe71a4 into development Jan 31, 2023
@DylanVerstraete DylanVerstraete deleted the development_delete_twin_not_allowed branch January 31, 2023 08:42
DylanVerstraete added a commit that referenced this pull request Apr 12, 2023
@DylanVerstraete @renauter
@omahs @LeeSmet @robvanmieghem @brandonpille
2.3.0 (#655)
140c58c 
* feat: rework documentation (#571)

* doc: service consumer contract flow (#567)

* fix: farming policies map ids (#591)

* chore: reset runtime migrations

* feat: delete twin is not allowed (#586)

* fix: typos (#595)

* fix: locked balances (#590)

* feat: allow twin to connect to a relay (#570)

* chore: bump to version 2.3.0-rc1 (specVersion: 124)

* feat: add node power (#592)

* chore: update ADR docs

* chore: bump to version 2.3.0-rc2 (specVersion: 125)

* chore: rework logging pallet smart contract

* fix: allow numbers in relay addresses

* chore: bump to version 2.3.0-rc3 (specVersion: 125)

* fix: migration V15 for devnet #598

* chore: bump to version 2.3.0-rc4 (specVersion: 127)

* chore: restore V15 migration

* chore: update dev chain spec

* fix: soften serial number validation (#603)

* chore: set max length of serial number to 128 bytes

* chore: align tft bridge dependency

* chore: update default dev chainspec

* chore: revert default dev bridge validators chainspec

* Drop unused structopt dependency

This also removes some unused child dependencies

Signed-off-by: Lee Smet <lee.smet@hotmail.com>

* Set the substrate node default chart image to ghcr.io

* fix: rework balances migrations

* chore: refactor

* feat: also remove contract and lock if twin is deleted

* chore: add writes

* chore: resolve comment

* chore: fix ci

* chore: resolve pr comments

* chore: add log

* Update build_test.yaml to use the new runner (#617)

* chore: remove serial valdiation (#616)

* chore: bump to version 2.3.0-rc6 (specVersion: 129)

* chore: rework chart #620

* fix: discount calculation handle variable billing frequency (#626)

* fix: migrations for v2.3.0 (#627)

* chore: bump to version 2.3.0-rc7 (specVersion: 130)

* fix: soften node city/country validation

* chore: bump to version 2.3.0-rc8 (specVersion: 131)

* chore: update cargo lock

* chore: bump version to 2.3.0

---------

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
Co-authored-by: Erwan Renaut <73958772+renauter@users.noreply.github.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Co-authored-by: Lee Smet <lee.smet@hotmail.com>
Co-authored-by: Rob Van Mieghem <robvanmieghem@gmail.com>
Co-authored-by: Brandon <brandon@threefold.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@brandonpille brandonpille brandonpille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renauter @DylanVerstraete @brandonpille