Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: soften serial number validation #603

Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: soften serial number validation #603

merged 2 commits into from
Feb 14, 2023

Conversation

DylanVerstraete
Copy link
Contributor

@DylanVerstraete DylanVerstraete commented Feb 14, 2023 •
edited
Loading

  • Removes min lenght from serial number validation
  • Allows whitespaces

brandonpille
brandonpille approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@brandonpille brandonpille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

LeeSmet
LeeSmet requested changes Feb 14, 2023
View reviewed changes
substrate-node/pallets/pallet-tfgrid/src/tests.rs Outdated
@@ -2293,7 +2293,7 @@ fn create_node() {
interfaces,
true,
true,
None,
Some("Default String".as_bytes().to_vec().try_into().unwrap()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Default String".as_bytes() -> b"Default String"

@DylanVerstraete DylanVerstraete merged commit 15d9f5d into development Feb 14, 2023
@DylanVerstraete DylanVerstraete deleted the fix_serial_validation_dev branch February 14, 2023 13:48
renauter
renauter reviewed Feb 14, 2023
View reviewed changes
substrate-node/pallets/pallet-tfgrid/src/node.rs
@@ -294,7 +294,6 @@ pub fn validate_longitude_input(input: &[u8]) -> bool {
}
}

pub const MIN_SERIAL_NUMBER_LENGTH: u32 = 10;
pub const MAX_SERIAL_NUMBER_LENGTH: u32 = 50;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we keep it to 50 or change it to 128?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, lets set it to 128

I merged and deployed previous PR because dev was blocked on this. Let's do this in followup pr

DylanVerstraete added a commit that referenced this pull request Apr 12, 2023
@DylanVerstraete @renauter
@omahs @LeeSmet @robvanmieghem @brandonpille
2.3.0 (#655)
140c58c 
* feat: rework documentation (#571)

* doc: service consumer contract flow (#567)

* fix: farming policies map ids (#591)

* chore: reset runtime migrations

* feat: delete twin is not allowed (#586)

* fix: typos (#595)

* fix: locked balances (#590)

* feat: allow twin to connect to a relay (#570)

* chore: bump to version 2.3.0-rc1 (specVersion: 124)

* feat: add node power (#592)

* chore: update ADR docs

* chore: bump to version 2.3.0-rc2 (specVersion: 125)

* chore: rework logging pallet smart contract

* fix: allow numbers in relay addresses

* chore: bump to version 2.3.0-rc3 (specVersion: 125)

* fix: migration V15 for devnet #598

* chore: bump to version 2.3.0-rc4 (specVersion: 127)

* chore: restore V15 migration

* chore: update dev chain spec

* fix: soften serial number validation (#603)

* chore: set max length of serial number to 128 bytes

* chore: align tft bridge dependency

* chore: update default dev chainspec

* chore: revert default dev bridge validators chainspec

* Drop unused structopt dependency

This also removes some unused child dependencies

Signed-off-by: Lee Smet <lee.smet@hotmail.com>

* Set the substrate node default chart image to ghcr.io

* fix: rework balances migrations

* chore: refactor

* feat: also remove contract and lock if twin is deleted

* chore: add writes

* chore: resolve comment

* chore: fix ci

* chore: resolve pr comments

* chore: add log

* Update build_test.yaml to use the new runner (#617)

* chore: remove serial valdiation (#616)

* chore: bump to version 2.3.0-rc6 (specVersion: 129)

* chore: rework chart #620

* fix: discount calculation handle variable billing frequency (#626)

* fix: migrations for v2.3.0 (#627)

* chore: bump to version 2.3.0-rc7 (specVersion: 130)

* fix: soften node city/country validation

* chore: bump to version 2.3.0-rc8 (specVersion: 131)

* chore: update cargo lock

* chore: bump version to 2.3.0

---------

Signed-off-by: Lee Smet <lee.smet@hotmail.com>
Co-authored-by: Erwan Renaut <73958772+renauter@users.noreply.github.com>
Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Co-authored-by: Lee Smet <lee.smet@hotmail.com>
Co-authored-by: Rob Van Mieghem <robvanmieghem@gmail.com>
Co-authored-by: Brandon <brandon@threefold.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renauter renauter renauter left review comments

@LeeSmet LeeSmet LeeSmet requested changes

@brandonpille brandonpille brandonpille approved these changes

@robvanmieghem robvanmieghem Awaiting requested review from robvanmieghem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DylanVerstraete @brandonpille @LeeSmet @renauter