Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Node Finder table with node cards #2057

Closed
AlaaElattar opened this issue Jan 22, 2024 · 19 comments
Closed

Replace Node Finder table with node cards #2057

AlaaElattar opened this issue Jan 22, 2024 · 19 comments
Assignees
Labels
priority_minor type_feature New feature or request
Milestone

Comments

@AlaaElattar
Copy link
Contributor

AlaaElattar commented Jan 22, 2024

Redesign Node Finder to display node cards similar to those used when deploying an app

@ramezsaeed ramezsaeed added this to the 2.4.0 milestone Jan 24, 2024
@ramezsaeed ramezsaeed added the type_feature New feature or request label Jan 24, 2024
@MohamedElmdary MohamedElmdary moved this to Accepted in 3.14.x Feb 14, 2024
@zaelgohary
Copy link
Contributor

@AlaaElattar Can you be more specific?

@AlaaElattar
Copy link
Contributor Author

@AlaaElattar Can you be more specific?

@xmonader wants node finder to look like node selection cards.
replace table with list of cards instead.

@xmonader
Copy link
Contributor

@AlaaElattar Can you be more specific?

@xmonader wants node finder to look like node selection cards.
replace table with list of cards instead.

If possible 🙈

@zaelgohary zaelgohary self-assigned this Mar 13, 2024
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Mar 13, 2024
@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.14.x Mar 13, 2024
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Mar 13, 2024
@zaelgohary
Copy link
Contributor

zaelgohary commented Mar 13, 2024

@xmonader something like this?

image

Should the changes be applied in dedicated nodes page also, or only in node finder page?

@zaelgohary
Copy link
Contributor

Work in progress:

Replaced table rows w node cards. Currently working on each card details.

@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.14.x Mar 14, 2024
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Mar 14, 2024
@zaelgohary
Copy link
Contributor

Work in Progress:

The node type used while deploying is different than the on used in nodes table which led to type mismatch and build failed. I'm still working on fixing the type errors.

@zaelgohary
Copy link
Contributor

Work in progress:

Still working on fixing node types.

@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.14.x Mar 18, 2024
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.4.0, 2.5.0 Mar 25, 2024
@MohamedElmdary MohamedElmdary modified the milestones: 2.5.0, 2.4.0 Mar 26, 2024
@AhmedHanafy725
Copy link
Contributor

AhmedHanafy725 commented Mar 26, 2024

@ehab-hassan @zaelgohary

in addition to the current card details, the following details should be added too

image

@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Mar 26, 2024
@zaelgohary
Copy link
Contributor

Work in progress:

Worked on the card design.

@ehab-hassan
Copy link
Contributor

Frame 327
maybe when hovering at CPU and Memory Chips show the rest of the details like the example at vast.ai

@zaelgohary
Copy link
Contributor

zaelgohary commented Mar 26, 2024

I implemented the following design. I'm not yet sure of the chip colors but what do you think as a start? @ehab-hassan

image

GPU nodes:

image

The reserve button is not shown because none of the dedicated nodes are up. but it'll be just as shown in your screenshot.

Nodes list in solutions:

image

@ehab-hassan
Copy link
Contributor

@zaelgohary nice!! are these the same color for status and type we used before?
image

and the rest is OK with gray and white text.

@zaelgohary zaelgohary changed the title Redesign Node Finder page to list list of nodes cards' like the one while deploying any app. Redesign the "Node Finder" to display node cards similar to those used when deploying an app Mar 26, 2024
@zaelgohary zaelgohary changed the title Redesign the "Node Finder" to display node cards similar to those used when deploying an app Replace Node Finder table with node cards Mar 26, 2024
@zaelgohary zaelgohary moved this from In Progress to Pending Review in 3.14.x Mar 28, 2024
@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.14.x Mar 28, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
version : f530d72
cpu and ram details are now integrated in node finder
node finder tables are now replaced with node cards like the

Image

https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=426661#case_4150459

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Mar 31, 2024
@ramezsaeed
Copy link
Contributor

ramezsaeed commented Mar 31, 2024

@khaledyoussef24

@ramezsaeed ramezsaeed moved this from Done to In Verification in 3.14.x Mar 31, 2024
@khaledyoussef24
Copy link
Contributor

will wait for a dedicated node to be freed so i can verify

@A-Harby
Copy link
Contributor

A-Harby commented Apr 1, 2024

UI color need to be fixed in the light mode.
image

@A-Harby A-Harby moved this from In Verification to Accepted in 3.14.x Apr 1, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Apr 1, 2024

Can you also add a message when there are no nodes available for the filters, something like 'No nodes available" instead of an empty table?

image

@zaelgohary zaelgohary mentioned this issue Apr 2, 2024
5 tasks
@zaelgohary
Copy link
Contributor

@khaledyoussef24 As for the reserve button, found some bugs and opened an issue for it. You can verify it once it's in verification

@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.14.x Apr 2, 2024
@zaelgohary zaelgohary moved this from In Progress to Pending Review in 3.14.x Apr 2, 2024
@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.14.x Apr 3, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
version : bef3f8f

there is a separate issue for the reserve button cards for the node finder is now verified .
message when there is no nodes are available is now added also

Image
Image

node cards

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

9 participants