-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Node Finder table with node cards #2057
Comments
@AlaaElattar Can you be more specific? |
@xmonader wants node finder to look like node selection cards. |
If possible 🙈 |
@xmonader something like this? Should the changes be applied in dedicated nodes page also, or only in node finder page? |
Work in progress: Replaced table rows w node cards. Currently working on each card details. |
Work in Progress: The node type used while deploying is different than the on used in nodes table which led to type mismatch and build failed. I'm still working on fixing the type errors. |
Work in progress: Still working on fixing node types. |
in addition to the current card details, the following details should be added too
|
Work in progress: Worked on the card design. |
I implemented the following design. I'm not yet sure of the chip colors but what do you think as a start? @ehab-hassan GPU nodes: The reserve button is not shown because none of the dedicated nodes are up. but it'll be just as shown in your screenshot. Nodes list in solutions: |
@zaelgohary nice!! are these the same color for status and type we used before? and the rest is OK with gray and white text. |
Node Finder
page to list list of nodes cards' like the one while deploying any app.
verified on devnet https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=426661#case_4150459 |
|
will wait for a dedicated node to be freed so i can verify |
@khaledyoussef24 As for the reserve button, found some bugs and opened an issue for it. You can verify it once it's in verification |
verified on devnet there is a separate issue for the reserve button cards for the node finder is now verified . |
Redesign Node Finder to display node cards similar to those used when deploying an app
The text was updated successfully, but these errors were encountered: