Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace nodes table w node cards #2422

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Replace nodes table w node cards #2422

merged 4 commits into from
Mar 28, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Mar 13, 2024 •
edited
Loading

Description

Replace nodes table w node cards

No filter applied:

image

Dedicated Nodes:

image

GPU Nodes

image

Changes

  • Redesign Node finder
  • Add guard in NodeDetailsCard to check for node type
  • Add price, rented, rentable, speed CPU version & memory type chips & uptime
  • Edit node details,
  • Update GridNode type in grid proxy
  • Update nodeInitializer
  • Remove unreserve from ReserveBtnAction
  • Remove table chip info as most chips has tooltips now
  • Reposition CPU tooltip so the linear progress could take the full width
  • Add tooltips for all chips except for GPU
  • Edit formatResourceSize so it would return rounded values if speed is true

Related Issues

Documentation PR

For UI changes, please provide the documentation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Base automatically changed from development_314 to development March 18, 2024 13:07
@MohamedElmdary
Copy link
Member

@zaelgohary
Merge branch 'development' of https://github.com/threefoldtech/tfgrid…
4e7b6cc 
…-sdk-ts into development_314_redesign_node_finder
@zaelgohary
Add price, rented, rentable, speed cpu version & memory type chips + …
7e188c6 
…uptime, fix build, fix node details, update GridNode type in grid proxy, update nodeInitializer, edit unreserve btn, replace & restyle table chip info
@zaelgohary
Edit formatResourceSize to return rounded values if speed is true, ad…
a6202e6 
…d tooltips to most chips, remove unnecessary chip info alert
@zaelgohary zaelgohary marked this pull request as ready for review March 27, 2024 20:34
@zaelgohary
Copy link
Contributor Author

All done.

AlaaElattar
AlaaElattar approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@xmonader xmonader merged commit f530d72 into development Mar 28, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_314_redesign_node_finder branch April 2, 2024 22:27
This was referenced Apr 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zaelgohary @MohamedElmdary @AlaaElattar @xmonader