Tighten up module mappers to prevent hard-to-debug bugs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Targeting this to 3.0.0 release. |
|
@thymikee Thank you! |
|
Do they have a due date for new jest release? |
|
No, it's done when it's done. Jest doesn't have any release scheduling/cycle yet. |
thymikee
force-pushed
the
fix-mappings
branch
from
968ffd6
to
49b3ffd
Compare
sharikovvladislav
added a commit
to sharikovvladislav/jest-preset-angular
that referenced
this pull request
Nov 28, 2017
* origin/master: Adds a warning about html transforms. (thymikee#94) Update README to include installation instructions. (thymikee#84) Add doctype to test environment (thymikee#78) v4.0.0 v4.0.0 changelog Update changelog for master v4.0.0-alpha.1 Use universal zone.js instead of node-only (thymikee#76) Add custom environment (thymikee#75) Add fakeAsync test v3.0.2 Clarify AngularJS support More accurate moduleNameMapper regexps (thymikee#71) Update CHANGELOG.md v3.0.1 Bump jest and ts-jest to v21 (thymikee#70) v3.0.0 Tighten up module mappers; bump jest (thymikee#53) Add section to troubleshooting about JS files transpiling (thymikee#68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Fixes #37
In #6 we introduced very loose
moduleNameMapperwhich resulted in couple of weird bugs and until next Jest release it's impossible to override it.This PR reverts it and adds some reasonable defaults.
Also, because of this
"(.*)"mapping, while debugging #41 on master version of Jest, I encountered an issue where one of the internal Jest modules was calling path matching the regexp, but couldn't find it undersrcdir. This surfaced only because Jest version on master supports checking if modules inmoduleNameMapperexist and throws otherwise.