Add section to troubleshooting about JS files transpiling #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
requested changes
Aug 26, 2017
README.md
Outdated
| "presets": ["env"] | ||
| } | ||
| ``` | ||
| 2. Specify jest how to transpile JS files in jest configuration: |
There was a problem hiding this comment.
Let's change it to:
Update Jest configuration (by default TypeScript process untranspiled JS files which is source of the problem):
README.md
Outdated
| @@ -178,6 +178,26 @@ By default Jest doesn't transform `node_modules`, because they should be valid J | |||
| ``` | |||
| This tells `ts-jest` (a preprocessor this preset using to transform TS files) to treat JS files the same as TS ones. | |||
|
|
|||
| #### Transpile js files through `babel-jest` | |||
| Some vendors publish their sources without transpiling. You need to say jest to transpile such files manually since `typescript` (and thus `ts-jest`) do not transpile them. | |||
| 1. Install `babel-preset-env` with npm or yarn and add `.babelrc` (or modify existing if needed) with that contents: | |||
There was a problem hiding this comment.
Remove the with npm or yarn part
README.md
Outdated
| @@ -178,6 +178,26 @@ By default Jest doesn't transform `node_modules`, because they should be valid J | |||
| ``` | |||
| This tells `ts-jest` (a preprocessor this preset using to transform TS files) to treat JS files the same as TS ones. | |||
|
|
|||
| #### Transpile js files through `babel-jest` | |||
| Some vendors publish their sources without transpiling. You need to say jest to transpile such files manually since `typescript` (and thus `ts-jest`) do not transpile them. | |||
There was a problem hiding this comment.
(and thus
ts-jestused by this preset)
|
I fixed everything. |
thymikee
approved these changes
Aug 26, 2017
|
🎉 |
sharikovvladislav
added a commit
to sharikovvladislav/jest-preset-angular
that referenced
this pull request
Nov 28, 2017
* origin/master: Adds a warning about html transforms. (thymikee#94) Update README to include installation instructions. (thymikee#84) Add doctype to test environment (thymikee#78) v4.0.0 v4.0.0 changelog Update changelog for master v4.0.0-alpha.1 Use universal zone.js instead of node-only (thymikee#76) Add custom environment (thymikee#75) Add fakeAsync test v3.0.2 Clarify AngularJS support More accurate moduleNameMapper regexps (thymikee#71) Update CHANGELOG.md v3.0.1 Bump jest and ts-jest to v21 (thymikee#70) v3.0.0 Tighten up module mappers; bump jest (thymikee#53) Add section to troubleshooting about JS files transpiling (thymikee#68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @thymikee @DorianGrey
Did I write everything correct?
Sorry for possible mistakes (English is not my native language😿 ).